Fix linting issues detected by the latest pylint version

Change-Id: I47997a2d17733811013aa5c0da654ea16bc30496

Author: nmariz

lib/mysql/connector/connection_cext.py

@@ -33,7 +33,7 @@
 import socket
 
 from . import version
-from .abstracts import MySQLConnectionAbstract, MySQLCursorAbstract
+from .abstracts import MySQLConnectionAbstract
 from .constants import CharacterSet, ClientFlag, FieldFlag, ServerFlag, ShutdownType
 from .errors import (
     InterfaceError,

lib/mysql/connector/cursor.py

@@ -359,10 +359,6 @@ def _check_executed(self):
         if self._executed is None:
             raise InterfaceError(ERR_NO_RESULT_TO_FETCH)
 
-    def next(self):
-        """Used for iterating over the result set."""
-        return self.__next__()
-
     def __next__(self):
         """
         Used for iterating over the result set. Calles self.fetchone()

lib/mysql/connector/protocol.py

@@ -162,7 +162,7 @@ def make_conn_attrs(conn_attrs):
             if conn_attrs[attr_name] is None:
                 conn_attrs[attr_name] = ""
         conn_attrs_len = (
-            sum([len(x) + len(conn_attrs[x]) for x in conn_attrs])
+            sum(len(x) + len(conn_attrs[x]) for x in conn_attrs)
             + len(conn_attrs.keys())
             + len(conn_attrs.values())
         )
@@ -810,8 +810,7 @@ def make_stmt_execute(
                     "Failed executing prepared statement: data values does not"
                     " match number of parameters"
                 )
-            for pos, _ in enumerate(data):
-                value = data[pos]
+            for pos, value in enumerate(data):
                 _flags = 0
                 if value is None:
                     null_bitmap[(pos // 8)] |= 1 << (pos % 8)

lib/mysqlx/connection.py

@@ -2224,7 +2224,7 @@ def use_pure(self):
         return Protobuf.use_pure
 
     @use_pure.setter
-    def use_pure(self, value):  # pylint: disable=no-self-use
+    def use_pure(self, value):
         if not isinstance(value, bool):
             raise ProgrammingError("'use_pure' option should be True or False")
         Protobuf.set_use_pure(value)

lib/mysqlx/protocol.py

@@ -431,11 +431,12 @@ def _get_binding_args(self, stmt, is_scalar=True):
         Returns:
             list: A list of ``Any`` or ``Scalar`` objects.
         """
-        build_value = (
-            lambda value: build_scalar(value).get_message()
-            if is_scalar
-            else self._create_any(value).get_message()
-        )
+
+        def build_value(value):
+            if is_scalar:
+                return build_scalar(value).get_message()
+            return self._create_any(value).get_message()
+
         bindings = stmt.get_bindings()
         binding_map = stmt.get_binding_map()
 

lib/mysqlx/statement.py

@@ -731,7 +731,7 @@ def __init__(self, update_type, source, value=None):
             try:
                 self.source = ExprParser(source, False).document_field().identifier
             except ValueError as err:
-                raise ProgrammingError(f"{err}")
+                raise ProgrammingError(f"{err}") from err
             self.value = value
 
     def _table_set(self, source, value):

tests/test_cursor.py

@@ -335,11 +335,12 @@ def __init__(self):
 
     def test_next(self):
         """MySQLCursor object next()-method"""
-        self.check_method(self.cur, "next")
+        self.check_method(self.cur, "__next__")
 
         self.cnx = connection.MySQLConnection(**tests.get_mysql_config())
         self.cur = cursor.MySQLCursor(self.cnx)
         self.assertRaises(StopIteration, self.cur.__next__)
+        self.assertRaises(StopIteration, next, self.cur)
         self.cur.execute("SELECT BINARY 'ham'")
         exp = (bytearray(b"ham"),)
         self.assertEqual(exp, next(self.cur))