BUG#28491115: Connector/Python crashes on 0 time value

The Connector/Python binary protocol implemented in
MySQLProtocol._parse_binary_time() crashes on time value of 0
because it does not deal with payload of size 0 correctly.

Expected behavior is to receive a 00:00:00 time when using a
0-time value payload. With this patch, the issue is fixed by
addressing the edge case in which packet size is 0.

This patch also fixes BUG#34006512 (Connector/Python Throws
Exception When Time Field Is 0).

Change-Id: If5efa22812215fb90c86589aed5ca1084b79723f

Author: oscpache

CHANGES.txt

@@ -8,6 +8,11 @@ Copyright (c) 2009, 2022, Oracle and/or its affiliates.
 Full release notes:
  http://dev.mysql.com/doc/relnotes/connector-python/en/
 
+v8.0.31
+=======
+
+- BUG#28491115: Connector/Python crashes on 0 time value
+
 v8.0.30
 =======
 

lib/mysql/connector/protocol.py

@@ -539,6 +539,8 @@ def _parse_binary_timestamp(packet):
     def _parse_binary_time(packet):
         """Parse a time value from a binary packet"""
         length = packet[0]
+        if not length:
+            return (packet[1:], datetime.timedelta())
         data = packet[1 : length + 1]
         mcs = 0
         if length > 8:

tests/test_bugs.py

@@ -46,6 +46,7 @@
 import os
 import pickle
 import platform
+import struct
 import sys
 import tempfile
 import time
@@ -6940,3 +6941,41 @@ def test_no_backslash_escapes(self):
             self.assertEqual(res[0][0], "test")
             self.assertEqual(self.cnx.sql_mode, "NO_BACKSLASH_ESCAPES")
             cur.execute(f"DROP TABLE IF EXISTS {table}")
+
+
+class BugOra28491115(tests.MySQLConnectorTests):
+    """BUG#28491115: MySQL-Connector-Python Crashes On 0 Time Value.
+
+    a) The mysql-python-connector binary protocol appears to crash on
+    time value of 0 because it does not deal with payload of size 0
+    correctly.
+    b) When querying a TIME field that is set to 00:00:00,
+    mysql.connector throws an exception when trying to unpack the
+    result.
+
+    Also fixes BUG#34006512 (Mysql.Connector Throws Exception When Time Field Is 0).
+    """
+
+    @foreach_cnx()
+    def test_crash_on_time_0value(self):
+        table_name = "BugOra28491115"
+        with self.cnx.cursor(prepared=True) as cur:
+            cur.execute(f"DROP TABLE IF EXISTS {table_name}")
+            cur.execute(f"CREATE TABLE {table_name} (a TIME)")
+            cur.execute(f"INSERT INTO {table_name} VALUES (0)")
+            cur.execute(f"SELECT * FROM {table_name}")
+            res = cur.fetchall()
+            self.assertEqual(res[0][0], timedelta(0))
+            cur.execute(f"DROP TABLE IF EXISTS {table_name}")
+
+    @foreach_cnx()
+    def test_exception_when_time_field_is_0(self):
+        table_name = "BugOra34006512"
+        with self.cnx.cursor(prepared=True) as cur:
+            cur.execute(f"DROP TABLE IF EXISTS {table_name}")
+            cur.execute(f"CREATE TEMPORARY TABLE {table_name} (b TIME)")
+            cur.execute(f"INSERT INTO {table_name} SET b='00:00'")
+            cur.execute(f"SELECT * FROM {table_name}")
+            res = cur.fetchall()
+            self.assertEqual(res[0][0], timedelta(0))
+            cur.execute(f"DROP TABLE IF EXISTS {table_name}")

tests/test_protocol.py

@@ -431,6 +431,10 @@ def test__parse_binary_time(self):
                 datetime.timedelta(10, 58530, 230000),
                 bytearray(b"\x0c\x00\x0a\x00\x00\x00" b"\x10\x0f\x1e\x70\x82\x03\x00"),
             ),
+            (
+                datetime.timedelta(0),
+                bytearray(b"\x00"),
+            ),
         ]
         for exp, data in cases:
             res = self._protocol._parse_binary_time(data + b"\x00\x00")