Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus-community/postgres_exporter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mjl-/postgres_exporter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 2 commits
  • 1,306 files changed
  • 1 contributor

Commits on Jun 14, 2019

  1. update to lib/pq v1.1.1 with SCRAM auth support as used by postgres11… 

    …, and modernize to go modules

Make building simpler:
- move cmd/postgres_exporter to .
- use go build, not mage
- add a docker-compose file that spawns all postgres versions and run tests against each of them.
- remove the tools directory with linting tools. i've run golangci-lint locally.
- no copying of assets

Not done:
- travis ci tests
- running (passing) the existing integration tests
- running golangci-lint automatically (instead of the old linters). but then probably run it through docker. the source has a lot of go dependencies, don't want to make our go.mod huge. the alternative is a separate tools dir and go.mod file (instead of a tools.go in the root dir).
- increasing test coverage
    @mjl-
    mjl- committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    13f2206 View commit details
    Browse the repository at this point in the history

  2. remove tools.go with golangci-lint 

    shouldn't have been committed
    @mjl-
    mjl- committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    dce70f3 View commit details
    Browse the repository at this point in the history
Loading