Skip to content

Wrong return type in librispeech model_fn #762

@Niccolo-Ajroldi

Description

@Niccolo-Ajroldi

In librispeech_conformer the model_fn returns logits_batch as a Tuple of tensors, not a tensor.

The return type is hence wrong:

update_batch_norm: bool) -> Tuple[spec.Tensor, spec.ModelAuxiliaryState]:

It should be:

  def model_fn(...) -> Tuple[Tuple[spec.Tensor, spec.Tensor], spec.ModelAuxiliaryState]:

As insignificant as it seems, this caused me quite some trouble debugging an OOM issue. Might be useful for other ppl too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions