Skip to content

Commit 9499949

Browse files
weltlingmichael-grunder
authored andcommitted
fix random() vs php_rand() for portability
Conflicts: library.c
1 parent 42535bd commit 9499949

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

library.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,9 @@ PHP_REDIS_API int redis_check_eof(RedisSock *redis_sock TSRMLS_DC)
187187
}
188188
// Wait for a while before trying to reconnect
189189
if (redis_sock->retry_interval) {
190-
// Random factor to avoid having several (or many) concurrent
191-
// connections trying to reconnect at the same time
192-
long retry_interval = (count ? redis_sock->retry_interval
193-
: (random() % redis_sock->retry_interval));
194-
195-
usleep(retry_interval);
190+
// Random factor to avoid having several (or many) concurrent connections trying to reconnect at the same time
191+
long retry_interval = (count ? redis_sock->retry_interval : (php_rand(TSRMLS_C) % redis_sock->retry_interval));
192+
usleep(retry_interval);
196193
}
197194
redis_sock_connect(redis_sock TSRMLS_CC); /* reconnect */
198195
if(redis_sock->stream) { /* check for EOF again. */

0 commit comments

Comments
 (0)