fix(afs): Better handle enablePersistence failures, esp. for Universal (angular#1850)

Author: jamesdaniels

src/firestore/firestore.ts

@@ -2,13 +2,14 @@ import { InjectionToken, NgZone, PLATFORM_ID, Injectable, Inject, Optional } fro
 
 import { Observable, of, from } from 'rxjs';
 import { catchError } from 'rxjs/operators';
-import { firestore } from 'firebase';
+import { firestore } from 'firebase/app';
 
 import { Settings, CollectionReference, DocumentReference, QueryFn, AssociatedReference } from './interfaces';
 import { AngularFirestoreDocument } from './document/document';
 import { AngularFirestoreCollection } from './collection/collection';
 
 import { FirebaseFirestore, FirebaseOptions, FirebaseAppConfig, FirebaseOptionsToken, FirebaseNameOrConfigToken, _firebaseAppFactory, FirebaseZoneScheduler } from 'angularfire2';
+import { isPlatformBrowser } from '@angular/common';
 
 /**
  * The value of this token determines whether or not the firestore will have persistance enabled
@@ -119,13 +120,20 @@ export class AngularFirestore {
       return firestore;
     });
 
-    this.persistenceEnabled$ = zone.runOutsideAngular(() =>
-        shouldEnablePersistence ? from(this.firestore.enablePersistence().then(() => true, () => false))
-                                : of(false)
-      )
-      .pipe(
-        catchError(() => of(false))
-      ); // https://github.com/firebase/firebase-js-sdk/issues/608
+    if (shouldEnablePersistence && isPlatformBrowser(platformId)) {
+      // We need to try/catch here because not all enablePersistence() failures are caught
+      // https://github.com/firebase/firebase-js-sdk/issues/608
+      const enablePersistence = () => {
+        try {
+          return from(this.firestore.enablePersistence().then(() => true, () => false));
+        } catch(e) {
+          return of(false);
+        }
+      };
+      this.persistenceEnabled$ = zone.runOutsideAngular(enablePersistence);
+    } else {
+      this.persistenceEnabled$ = of(false);
+    }
   }
 
   /**