Skip to content

Commit ffea45b

Browse files
joerg-krausecdunn2001
authored andcommitted
Remove Werror
-Werror shouldn't be used in released code since it can cause random build failures on moderate warnings. It also depends on the used toolchain since different toolchains may or may not print the same warnings.
1 parent 1b32e3e commit ffea45b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
101101
elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
102102
# using GCC
103103
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall -Wshadow -Wextra -pedantic -Wno-long-long")
104-
# not yet ready for -Wconversion
104+
# not yet ready for -Wsign-conversion
105105
endif()
106106

107107
IF(JSONCPP_WITH_WARNING_AS_ERROR)

0 commit comments

Comments
 (0)