improved test coverage

Author: cseufert

src/parser/expr.js

@@ -609,7 +609,7 @@ module.exports = {
     const node = this.node("match");
     this.expect(this.tok.T_MATCH) && this.next();
     if (this.version < 800) {
-      this.reaseError("Match statements are not allowed before PHP 8");
+      this.raiseError("Match statements are not allowed before PHP 8");
     }
     let cond = null;
     let arms = [];

test/snapshot/__snapshots__/match.test.js.snap

@@ -73,6 +73,71 @@ Program {
 }
 `;
 
+exports[`match can have hanging comma 1`] = `
+Program {
+  "children": Array [
+    ExpressionStatement {
+      "expression": Assign {
+        "kind": "assign",
+        "left": Variable {
+          "curly": false,
+          "kind": "variable",
+          "name": "test",
+        },
+        "operator": "=",
+        "right": Match {
+          "arms": Array [
+            MatchArm {
+              "body": String {
+                "isDoubleQuote": false,
+                "kind": "string",
+                "raw": "'ok'",
+                "unicode": false,
+                "value": "ok",
+              },
+              "conds": Array [
+                Boolean {
+                  "kind": "boolean",
+                  "raw": "true",
+                  "value": true,
+                },
+              ],
+              "kind": "matcharm",
+            },
+            MatchArm {
+              "body": String {
+                "isDoubleQuote": false,
+                "kind": "string",
+                "raw": "'Nope!'",
+                "unicode": false,
+                "value": "Nope!",
+              },
+              "conds": Array [
+                Boolean {
+                  "kind": "boolean",
+                  "raw": "false",
+                  "value": false,
+                },
+              ],
+              "kind": "matcharm",
+            },
+          ],
+          "cond": Variable {
+            "curly": false,
+            "kind": "variable",
+            "name": "test",
+          },
+          "kind": "match",
+        },
+      },
+      "kind": "expressionstatement",
+    },
+  ],
+  "errors": Array [],
+  "kind": "program",
+}
+`;
+
 exports[`match can have lhs, functions 1`] = `
 Program {
   "children": Array [

test/snapshot/match.test.js

@@ -6,7 +6,7 @@ describe("match", () => {
     $test = match($a) {
       true => 'yes',
       false => 'no',
-      default => null,
+      default => null
     };
     `);
     expect(ast).toMatchSnapshot();
@@ -16,7 +16,7 @@ describe("match", () => {
     const ast = parser.parseEval(`
     $test = match(true) {
       test($a), abc($b) => 'yes',
-      default => null,
+      default => null
     };
     `);
     expect(ast).toMatchSnapshot();
@@ -26,9 +26,28 @@ describe("match", () => {
     const ast = parser.parseEval(`
     $test = match(trye) {
       0,1,2,3 => run(),
-      default => null,
+      default => null
     };
     `);
     expect(ast).toMatchSnapshot();
   });
+  it("can have hanging comma", () => {
+    const ast = parser.parseEval(`
+    $test = match($test) {
+      true => 'ok',
+      false => 'Nope!',
+    };
+    `);
+    expect(ast).toMatchSnapshot();
+  });
+  it("does not support older php than 8", () => {
+    expect(() => {
+      new parser({ parser: { version: 704 } }).parseEval(`
+        $test = match($test) {
+          true => 'ok',
+          false => 'Nope!',
+        };
+    `);
+    }).toThrow(SyntaxError);
+  });
 });