Merge pull request glayzzle#580 from glayzzle/fix-nested-list-assignment

fix: parse nested shorthand lists as lists

Author: ichiriac

src/parser/expr.js

@@ -489,7 +489,7 @@ module.exports = {
       expr = this.read_scalar();
       if (expr.kind === "array" && expr.shortForm && this.token === "=") {
         // list assign
-        const list = this.node("list")(expr.items, true);
+        const list = this.convertToList(expr);
         if (expr.loc) list.loc = expr.loc;
         const right = this.next().read_expr();
         return result("assign", list, right, "=");
@@ -508,6 +508,27 @@ module.exports = {
     return expr;
   },
 
+  /**
+   * Recursively convert nested array to nested list.
+   */
+  convertToList: function (array) {
+    const convertedItems = array.items.map((entry) => {
+      if (
+        entry.value &&
+        entry.value.kind === "array" &&
+        entry.value.shortForm
+      ) {
+        entry.value = this.convertToList(entry.value);
+      }
+      return entry;
+    });
+    const node = this.node("list")(convertedItems, true);
+    if (array.loc) node.loc = array.loc;
+    if (array.leadingComments) node.leadingComments = array.leadingComments;
+    if (array.trailingComments) node.trailingComments = array.trailingComments;
+    return node;
+  },
+
   /**
    * Reads assignment
    * @param {*} left

test/snapshot/__snapshots__/acid.test.js.snap

@@ -7540,7 +7540,7 @@ next:
                     },
                   },
                   "unpack": false,
-                  "value": Array {
+                  "value": List {
                     "items": Array [
                       Entry {
                         "byRef": false,
@@ -7633,7 +7633,7 @@ next:
                         },
                       },
                     ],
-                    "kind": "array",
+                    "kind": "list",
                     "loc": Location {
                       "end": Position {
                         "column": 16,