Skip to content

Commit 557c765

Browse files
author
Stephane Landelle
committed
WebSocketUpgradeHandler doesn't need to be threadsafe
1 parent 8daab9e commit 557c765

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/main/java/com/ning/http/client/websocket/WebSocketUpgradeHandler.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
import com.ning.http.client.HttpResponseStatus;
1919
import com.ning.http.client.UpgradeHandler;
2020

21-
import java.util.concurrent.ConcurrentLinkedQueue;
21+
import java.util.ArrayList;
22+
import java.util.List;
2223
import java.util.concurrent.atomic.AtomicBoolean;
2324

2425
/**
@@ -27,12 +28,12 @@
2728
public class WebSocketUpgradeHandler implements UpgradeHandler<WebSocket>, AsyncHandler<WebSocket> {
2829

2930
private WebSocket webSocket;
30-
private final ConcurrentLinkedQueue<WebSocketListener> listeners;
31+
private final List<WebSocketListener> listeners;
3132
private final AtomicBoolean ok = new AtomicBoolean(false);
3233
private final AtomicBoolean onSuccessCalled = new AtomicBoolean(false);
3334
private int status;
3435

35-
protected WebSocketUpgradeHandler(ConcurrentLinkedQueue<WebSocketListener> listeners) {
36+
protected WebSocketUpgradeHandler(List<WebSocketListener> listeners) {
3637
this.listeners = listeners;
3738
}
3839

@@ -126,7 +127,7 @@ public void onClose(WebSocket webSocket, int status, String reasonPhrase) {
126127
*/
127128
public final static class Builder {
128129

129-
private ConcurrentLinkedQueue<WebSocketListener> listeners = new ConcurrentLinkedQueue<WebSocketListener>();
130+
private List<WebSocketListener> listeners = new ArrayList<WebSocketListener>(1);
130131

131132
/**
132133
* Add a {@link WebSocketListener} that will be added to the {@link WebSocket}

0 commit comments

Comments
 (0)