Clean up warnings

Author: Stephane Landelle

src/main/java/com/ning/http/client/AsyncHttpClient.java

@@ -482,6 +482,7 @@ public BoundRequestBuilder prepareRequest(Request request) {
      * @return a {@link Future} of type T
      * @throws IOException
      */
+    @SuppressWarnings({ "rawtypes", "unchecked" })
     public <T> ListenableFuture<T> executeRequest(Request request, AsyncHandler<T> handler) throws IOException {
 
         FilterContext fc = new FilterContext.FilterContextBuilder().asyncHandler(handler).request(request).build();
@@ -497,6 +498,7 @@ public <T> ListenableFuture<T> executeRequest(Request request, AsyncHandler<T> h
      * @return a {@link Future} of type Response
      * @throws IOException
      */
+    @SuppressWarnings({ "rawtypes", "unchecked" })
     public ListenableFuture<Response> executeRequest(Request request) throws IOException {
         FilterContext fc = new FilterContext.FilterContextBuilder().asyncHandler(new AsyncCompletionHandlerBase()).request(request).build();
         fc = preProcessRequest(fc);
@@ -509,6 +511,7 @@ public ListenableFuture<Response> executeRequest(Request request) throws IOExcep
      * @param fc {@link FilterContext}
      * @return {@link FilterContext}
      */
+    @SuppressWarnings("rawtypes")
     private FilterContext preProcessRequest(FilterContext fc) throws IOException {
         for (RequestFilter asyncFilter : config.getRequestFilters()) {
             try {

src/main/java/com/ning/http/client/extra/ResumableRandomAccessFileListener.java

@@ -14,9 +14,6 @@
 
 import com.ning.http.client.resumable.ResumableListener;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import java.io.IOException;
 import java.io.RandomAccessFile;
 import java.nio.ByteBuffer;
@@ -26,7 +23,6 @@
  */
 public class ResumableRandomAccessFileListener implements ResumableListener {
     private final RandomAccessFile file;
-    private final static Logger logger = LoggerFactory.getLogger(ThrottleRequestFilter.class);
 
     public ResumableRandomAccessFileListener(RandomAccessFile file) {
         this.file = file;

src/main/java/com/ning/http/client/extra/ThrottleRequestFilter.java

@@ -46,6 +46,7 @@ public ThrottleRequestFilter(int maxConnections, int maxWait) {
     }
 
     @Override
+    @SuppressWarnings({ "rawtypes", "unchecked" })
     public FilterContext filter(FilterContext ctx) throws FilterException {
 
         try {

src/main/java/com/ning/http/client/filter/FilterContext.java

@@ -33,14 +33,15 @@
  */
 public class FilterContext<T> {
 
+    @SuppressWarnings("rawtypes")
     private final FilterContextBuilder b;
 
     /**
      * Create a new {@link FilterContext}
      *
      * @param b a {@link FilterContextBuilder}
      */
-    private FilterContext(FilterContextBuilder b) {
+    private FilterContext(@SuppressWarnings("rawtypes") FilterContextBuilder b) {
         this.b = b;
     }
 
@@ -49,6 +50,7 @@ private FilterContext(FilterContextBuilder b) {
      *
      * @return the original or decorated {@link AsyncHandler}
      */
+    @SuppressWarnings("unchecked")
     public AsyncHandler<T> getAsyncHandler() {
         return b.asyncHandler;
     }
@@ -107,6 +109,7 @@ public static class FilterContextBuilder<T> {
         public FilterContextBuilder() {
         }
 
+        @SuppressWarnings({ "rawtypes", "unchecked" })
         public FilterContextBuilder(FilterContext clone) {
             asyncHandler = clone.getAsyncHandler();
             request = clone.getRequest();
@@ -119,6 +122,7 @@ public AsyncHandler<T> getAsyncHandler() {
             return asyncHandler;
         }
 
+        @SuppressWarnings("rawtypes")
         public FilterContextBuilder asyncHandler(AsyncHandler<T> asyncHandler) {
             this.asyncHandler = asyncHandler;
             return this;
@@ -128,34 +132,39 @@ public Request getRequest() {
             return request;
         }
 
+        @SuppressWarnings("rawtypes")
         public FilterContextBuilder request(Request request) {
             this.request = request;
             return this;
         }
 
+        @SuppressWarnings("rawtypes")
         public FilterContextBuilder responseStatus(HttpResponseStatus responseStatus) {
             this.responseStatus = responseStatus;
             return this;
         }
 
+        @SuppressWarnings("rawtypes")
         public FilterContextBuilder responseHeaders(HttpResponseHeaders headers) {
             this.headers = headers;
             return this;
         }
 
+        @SuppressWarnings("rawtypes")
         public FilterContextBuilder replayRequest(boolean replayRequest) {
             this.replayRequest = replayRequest;
             return this;
         }
 
+        @SuppressWarnings("rawtypes")
         public FilterContextBuilder ioException(IOException ioException) {
             this.ioException = ioException;
             return this;
         }
 
+        @SuppressWarnings("rawtypes")
         public FilterContext build() {
             return new FilterContext(this);
         }
     }
-
 }

src/main/java/com/ning/http/client/filter/FilterException.java

@@ -16,6 +16,7 @@
  * An exception that can be thrown by an {@link com.ning.http.client.AsyncHandler} to interrupt invocation of
  * the {@link RequestFilter} and {@link ResponseFilter}. It also interrupt the request and response processing.
  */
+@SuppressWarnings("serial")
 public class FilterException extends Exception {
 
     /**

src/main/java/com/ning/http/client/filter/IOExceptionFilter.java

@@ -25,5 +25,6 @@ public interface IOExceptionFilter {
      * @return {@link FilterContext}. The {@link FilterContext} instance may not the same as the original one.
      * @throws FilterException to interrupt the filter processing.
      */
+    @SuppressWarnings("rawtypes")
     FilterContext filter(FilterContext ctx) throws FilterException;
 }

src/main/java/com/ning/http/client/filter/RequestFilter.java

@@ -26,5 +26,6 @@ public interface RequestFilter {
      * @return {@link FilterContext}. The {@link FilterContext} instance may not the same as the original one.
      * @throws FilterException to interrupt the filter processing.
      */
+    @SuppressWarnings("rawtypes")
     FilterContext filter(FilterContext ctx) throws FilterException;
 }

src/main/java/com/ning/http/client/filter/ResponseFilter.java

@@ -29,5 +29,6 @@ public interface ResponseFilter {
      * @return {@link FilterContext}. The {@link FilterContext} instance may not the same as the original one.
      * @throws FilterException to interrupt the filter processing.
      */
+    @SuppressWarnings("rawtypes")
     FilterContext filter(FilterContext ctx) throws FilterException;
 }

src/main/java/com/ning/http/client/listener/TransferCompletionHandler.java

@@ -22,7 +22,6 @@
 import com.ning.http.client.Response;
 
 import java.util.concurrent.ConcurrentLinkedQueue;
-import java.util.concurrent.atomic.AtomicLong;
 
 /**
  * A {@link org.asynchttpclient.AsyncHandler} that can be used to notify a set of {@link TransferListener}

src/main/java/com/ning/http/client/providers/netty/request/NettyRequestSender.java

@@ -144,6 +144,7 @@ private <T> ListenableFuture<T> sendRequestWithCertainForceConnect(//
      * Loop until we get a valid channel from the pool and it's still valid
      * once the request is built
      */
+    @SuppressWarnings("unused")
     private <T> ListenableFuture<T> sendRequestThroughSslProxy(//
             Request request,//
             AsyncHandler<T> asyncHandler,//
@@ -450,6 +451,7 @@ public boolean applyIoExceptionFiltersAndReplayRequest(NettyResponseFuture<?> fu
 
         boolean replayed = false;
 
+        @SuppressWarnings({ "unchecked", "rawtypes" })
         FilterContext<?> fc = new FilterContext.FilterContextBuilder().asyncHandler(future.getAsyncHandler()).request(future.getRequest())
                 .ioException(e).build();
         for (IOExceptionFilter asyncFilter : config.getIOExceptionFilters()) {

src/main/java/com/ning/http/client/resumable/ResumableAsyncHandler.java

@@ -147,6 +147,7 @@ public AsyncHandler.STATE onBodyPartReceived(HttpResponseBodyPart bodyPart) thro
         return state;
     }
 
+    @SuppressWarnings("unchecked")
     @Override
     public T onCompleted() throws Exception {
         resumableProcessor.remove(url);
@@ -207,6 +208,7 @@ public Request adjustRequestRange(Request request) {
      * @param resumableListener a {@link ResumableListener}
      * @return this
      */
+    @SuppressWarnings("rawtypes")
     public ResumableAsyncHandler setResumableListener(ResumableListener resumableListener) {
         this.resumableListener = resumableListener;
         return this;

src/main/java/com/ning/http/client/resumable/ResumableIOExceptionFilter.java

@@ -22,6 +22,7 @@
  * a {@link ResumableAsyncHandler}
  */
 public class ResumableIOExceptionFilter implements IOExceptionFilter {
+    @SuppressWarnings("rawtypes")
     public FilterContext filter(FilterContext ctx) throws FilterException {
         if (ctx.getIOException() != null && ctx.getAsyncHandler() instanceof ResumableAsyncHandler) {
 

src/main/java/com/ning/http/client/websocket/WebSocketUpgradeHandler.java

@@ -28,6 +28,7 @@ public class WebSocketUpgradeHandler implements UpgradeHandler<WebSocket>, Async
 
     private WebSocket webSocket;
     private final ConcurrentLinkedQueue<WebSocketListener> l;
+    // FIXME use?
     private final String protocol;
     private final long maxByteSize;
     private final long maxTextSize;

src/main/java/com/ning/http/util/AsyncHttpProviderUtils.java

@@ -83,6 +83,7 @@ public final static byte[] contentToByte(List<HttpResponseBodyPart> bodyParts) t
         }
     }
 
+    @SuppressWarnings("resource")
     public final static InputStream contentToInputStream(List<HttpResponseBodyPart> bodyParts) throws UnsupportedEncodingException {
         return bodyParts.isEmpty() ? new ByteArrayInputStream(EMPTY_BYTE_ARRAY) : new HttpResponseBodyPartsInputStream(bodyParts);
     }

src/main/java/com/ning/http/util/ProxyHostnameChecker.java

@@ -33,6 +33,7 @@ public ProxyHostnameChecker() {
     private Object getHostnameChecker() {
         final ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
         try {
+            @SuppressWarnings("unchecked")
             final Class<Object> hostnameCheckerClass = (Class<Object>) classLoader.loadClass("sun.security.util.HostnameChecker");
             final Method instanceMethod = hostnameCheckerClass.getMethod("getInstance", Byte.TYPE);
             return instanceMethod.invoke(null, TYPE_TLS);