Curse people setting public modifier on interface methods

Author: Stephane Landelle

src/main/java/com/ning/http/client/AsyncHttpProvider.java

@@ -31,12 +31,12 @@ public interface AsyncHttpProvider {
      * @return a {@link ListenableFuture} of Type T.
      * @throws IOException
      */
-    public <T> ListenableFuture<T> execute(Request request, AsyncHandler<T> handler) throws IOException;
+    <T> ListenableFuture<T> execute(Request request, AsyncHandler<T> handler) throws IOException;
 
     /**
      * Close the current underlying TCP/HTTP connection.
      */
-    public void close();
+    void close();
 
     /**
      * Prepare a {@link Response}
@@ -46,8 +46,7 @@ public interface AsyncHttpProvider {
      * @param bodyParts list of {@link HttpResponseBodyPart}
      * @return a {@link Response}
      */
-    public Response prepareResponse(HttpResponseStatus status,
-                                    HttpResponseHeaders headers,
-                                    List<HttpResponseBodyPart> bodyParts);
-
+    Response prepareResponse(HttpResponseStatus status,
+                             HttpResponseHeaders headers,
+                             List<HttpResponseBodyPart> bodyParts);
 }

src/main/java/com/ning/http/client/AsyncHttpProviderConfig.java

@@ -29,28 +29,28 @@ public interface AsyncHttpProviderConfig<U, V> {
      * @param value the value of the property
      * @return this instance of AsyncHttpProviderConfig
      */
-    public AsyncHttpProviderConfig addProperty(U name, V value);
+    AsyncHttpProviderConfig addProperty(U name, V value);
 
     /**
      * Return the value associated with the property's name
      *
      * @param name
      * @return this instance of AsyncHttpProviderConfig
      */
-    public V getProperty(U name);
+    V getProperty(U name);
 
     /**
      * Remove the value associated with the property's name
      *
      * @param name
      * @return true if removed
      */
-    public V removeProperty(U name);
+    V removeProperty(U name);
 
     /**
      * Return the curent entry set.
      *
      * @return a the curent entry set.
      */
-    public Set<Map.Entry<U, V>> propertiesSet();
+    Set<Map.Entry<U, V>> propertiesSet();
 }

src/main/java/com/ning/http/client/Body.java

@@ -43,5 +43,4 @@ public interface Body {
      * @throws IOException
      */
     void close() throws IOException;
-
 }

src/main/java/com/ning/http/client/BodyConsumer.java

@@ -35,5 +35,4 @@ public interface BodyConsumer {
      * @throws IOException
      */
     void close() throws IOException;
-
 }

src/main/java/com/ning/http/client/BodyGenerator.java

@@ -28,7 +28,5 @@ public interface BodyGenerator {
      * @return The request body, never {@code null}.
      * @throws IOException If the body could not be created.
      */
-    Body createBody()
-            throws IOException;
-
+    Body createBody() throws IOException;
 }

src/main/java/com/ning/http/client/ConnectionPoolKeyStrategy.java

@@ -20,4 +20,4 @@
 public interface ConnectionPoolKeyStrategy {
 
 	String getKey(URI uri);
-}
+}

src/main/java/com/ning/http/client/ConnectionsPool.java

@@ -28,34 +28,34 @@ public interface ConnectionsPool<U, V> {
      * @param connection an I/O connection
      * @return true if added.
      */
-    public boolean offer(U uri, V connection);
+    boolean offer(U uri, V connection);
 
     /**
      * Remove the connection associated with the uri.
      *
      * @param uri the uri used when invoking addConnection
      * @return the connection associated with the uri
      */
-    public V poll(U uri);
+    V poll(U uri);
 
     /**
      * Remove all connections from the cache. A connection might have been associated with several uri.
      *
      * @param connection a connection
      * @return the true if the connection has been removed
      */
-    public boolean removeAll(V connection);
+    boolean removeAll(V connection);
 
     /**
      * Return true if a connection can be cached. A implementation can decide based on some rules to allow caching
      * Calling this method is equivalent of checking the returned value of {@link ConnectionsPool#offer(Object, Object)}
      *
      * @return true if a connection can be cached.
      */
-    public boolean canCacheConnection();
+    boolean canCacheConnection();
 
     /**
      * Destroy all connections that has been cached by this instance.
      */
-    public void destroy();
+    void destroy();
 }

src/main/java/com/ning/http/client/Part.java

@@ -20,5 +20,5 @@
  * Interface for the parts in a multipart request.
  */
 public interface Part {
-    public String getName();
-}
+    String getName();
+}

src/main/java/com/ning/http/client/ProgressAsyncHandler.java

@@ -44,5 +44,5 @@ public interface ProgressAsyncHandler<T> extends AsyncHandler<T> {
      * @return a {@link com.ning.http.client.AsyncHandler.STATE} telling to CONTINUE or ABORT the current processing.
      */
     STATE onContentWriteProgress(long amount, long current, long total);
-
 }
+

src/main/java/com/ning/http/client/ProxyServerSelector.java

@@ -24,3 +24,4 @@ public ProxyServer select(URI uri) {
         }
     };
 }
+

src/main/java/com/ning/http/client/RandomAccessBody.java

@@ -19,8 +19,7 @@
 /**
  * A request body which supports random access to its contents.
  */
-public interface RandomAccessBody
-        extends Body {
+public interface RandomAccessBody extends Body {
 
     /**
      * Transfers the specified chunk of bytes from this body to the specified channel.
@@ -33,5 +32,4 @@ public interface RandomAccessBody
      */
     long transferTo(long position, long count, WritableByteChannel target)
             throws IOException;
-
 }

src/main/java/com/ning/http/client/Request.java

@@ -44,7 +44,7 @@ public interface Request {
      * An entity that can be used to manipulate the Request's body output before it get sent.
      */
     public static interface EntityWriter {
-        public void writeEntity(OutputStream out) throws IOException;
+        void writeEntity(OutputStream out) throws IOException;
     }
 
     /**
@@ -53,191 +53,191 @@ public static interface EntityWriter {
      * @return the request's type (GET, POST, etc.)
      * @deprecated - use getMethod
      */
-    public String getReqType();
+    String getReqType();
 
     /**
      * Return the request's method name (GET, POST, etc.)
      *
      * @return the request's method name (GET, POST, etc.)
      */
-    public String getMethod();
+    String getMethod();
 
     /**
      * Return the decoded url
      *
      * @return the decoded url
      */
-    public String getUrl();
+    String getUrl();
 
-    public URI getOriginalURI();
-    public URI getURI();
-    public URI getRawURI();
+    URI getOriginalURI();
+    URI getURI();
+    URI getRawURI();
 
     /**
      * Return the InetAddress to override
      *
      * @return the InetAddress
      */
-    public InetAddress getInetAddress();
+    InetAddress getInetAddress();
 
-    public InetAddress getLocalAddress();
+    InetAddress getLocalAddress();
 
     /**
      * Return the undecoded url
      *
      * @return the undecoded url
      */
-    public String getRawUrl();
+    String getRawUrl();
 
     /**
      * Return the current set of Headers.
      *
      * @return a {@link FluentCaseInsensitiveStringsMap} contains headers.
      */
-    public FluentCaseInsensitiveStringsMap getHeaders();
+    FluentCaseInsensitiveStringsMap getHeaders();
 
     /**
      * Return Coookie.
      *
      * @return an unmodifiable Collection of Cookies
      */
-    public Collection<Cookie> getCookies();
+    Collection<Cookie> getCookies();
 
     /**
      * Return the current request's body as a byte array
      *
      * @return a byte array of the current request's body.
      */
-    public byte[] getByteData();
+    byte[] getByteData();
 
     /**
      * Return the current request's body as a string
      *
      * @return an String representation of the current request's body.
      */
-    public String getStringData();
+    String getStringData();
 
     /**
      * Return the current request's body as an InputStream
      *
      * @return an InputStream representation of the current request's body.
      */
-    public InputStream getStreamData();
+    InputStream getStreamData();
 
     /**
      * Return the current request's body as an EntityWriter
      *
      * @return an EntityWriter representation of the current request's body.
      */
-    public EntityWriter getEntityWriter();
+    EntityWriter getEntityWriter();
 
     /**
      * Return the current request's body generator.
      *
      * @return A generator for the request body.
      */
-    public BodyGenerator getBodyGenerator();
+    BodyGenerator getBodyGenerator();
 
     /**
      * Return the current size of the content-lenght header based on the body's size.
      *
      * @return the current size of the content-lenght header based on the body's size.
      * @deprecated
      */
-    public long getLength();
+    long getLength();
 
     /**
      * Return the current size of the content-lenght header based on the body's size.
      *
      * @return the current size of the content-lenght header based on the body's size.
      */
-    public long getContentLength();
+    long getContentLength();
 
     /**
      * Return the current parameters.
      *
      * @return a {@link FluentStringsMap} of parameters.
      */
-    public FluentStringsMap getParams();
+    FluentStringsMap getParams();
 
     /**
      * Return the current {@link Part}
      *
      * @return the current {@link Part}
      */
-    public List<Part> getParts();
+    List<Part> getParts();
 
     /**
      * Return the virtual host value.
      *
      * @return the virtual host value.
      */
-    public String getVirtualHost();
+    String getVirtualHost();
 
     /**
      * Return the query params.
      *
      * @return {@link FluentStringsMap} of query string
      */
-    public FluentStringsMap getQueryParams();
+    FluentStringsMap getQueryParams();
 
     /**
      * Return the {@link ProxyServer}
      *
      * @return the {@link ProxyServer}
      */
-    public ProxyServer getProxyServer();
+    ProxyServer getProxyServer();
 
     /**
      * Return the {@link Realm}
      *
      * @return the {@link Realm}
      */
-    public Realm getRealm();
+    Realm getRealm();
 
     /**
      * Return the {@link File} to upload.
      *
      * @return the {@link File} to upload.
      */
-    public File getFile();
+    File getFile();
 
     /**
      * Return the <tt>true></tt> to follow redirect
      *
      * @return the <tt>true></tt> to follow redirect
      */
-    public boolean isRedirectEnabled();
+    boolean isRedirectEnabled();
 
     /**
      *
      * @return <tt>true></tt> if request's redirectEnabled setting
      *          should be used in place of client's
      */
-    public boolean isRedirectOverrideSet();
+    boolean isRedirectOverrideSet();
 
     /**
      * Return Per request configuration.
      *
      * @return Per request configuration.
      */
-    public PerRequestConfig getPerRequestConfig();
+    PerRequestConfig getPerRequestConfig();
 
     /**
      * Return the HTTP Range header value, or
      *
      * @return the range header value, or 0 is not set.
      */
-    public long getRangeOffset();
+    long getRangeOffset();
 
     /**
      * Return the encoding value used when encoding the request's body.
      *
      * @return the encoding value used when encoding the request's body.
      */
-    public String getBodyEncoding();
+    String getBodyEncoding();
 
-    public boolean isUseRawUrl();
+    boolean isUseRawUrl();
 
     ConnectionPoolKeyStrategy getConnectionPoolKeyStrategy();
 }