chore: refactor test (sveltejs#263)

* chore: refactor tests

* remove the flaky test case

Author: tomoam

tests/focus_management.spec.ts

@@ -1,7 +1,6 @@
 import { expect, test } from '@playwright/test';
 
 const editor_selector = '.cm-content';
-const editor_focus_selector = '.cm-content';
 const iframe_selector = 'iframe[src*="webcontainer.io/"]';
 
 test.describe.configure({ mode: 'parallel' });
@@ -12,10 +11,11 @@ test('focus management: the editor keeps focus when iframe is loaded', async ({
 	await page.goto('/tutorial/your-first-component');
 
 	// first, focus the editor before the iframe is loaded
-	await page.locator(editor_selector).click({ delay: 1000 });
+	await page.waitForTimeout(1000);
+	await page.locator(editor_selector).click();
 
 	// at this time, expect focus to be on the editor
-	await expect(page.locator(editor_focus_selector)).toBeFocused();
+	await expect(page.locator(editor_selector)).toBeFocused();
 
 	// wait for the iframe to load
 	await page.frameLocator(iframe_selector).getByText('Hello world!').waitFor();
@@ -24,7 +24,7 @@ test('focus management: the editor keeps focus when iframe is loaded', async ({
 	await page.waitForTimeout(1000);
 
 	// expect focus to be on the editor
-	await expect(page.locator(editor_focus_selector)).toBeFocused();
+	await expect(page.locator(editor_selector)).toBeFocused();
 });
 
 test('focus management: input inside the iframe gets focus when clicking it', async ({ page }) => {
@@ -38,48 +38,21 @@ test('focus management: input inside the iframe gets focus when clicking it', as
 	await iframe.getByText('todos').waitFor();
 
 	// first, focus the editor
-	await page.locator(editor_selector).click({ delay: 1000 });
-	await expect(page.locator(editor_focus_selector)).toBeFocused();
+	await page.waitForTimeout(1000)
+	await page.locator(editor_selector).click();
+	await expect(page.locator(editor_selector)).toBeFocused();
 
 	// then, click a input in the iframe
 	const input = iframe.locator('input[name="description"]');
-	await input.click({ delay: 1000 });
+	await page.waitForTimeout(1000)
+	await input.click();
 
 	// wait a little, because there may be a script that manipulates focus
 	await page.waitForTimeout(1000);
 
 	// expect focus to be on the input in the iframe, not the editor.
 	await expect(input).toBeFocused();
-	await expect(page.locator(editor_focus_selector)).not.toBeFocused();
-});
-
-test('focus management: body inside the iframe gets focus when clicking a link inside the iframe', async ({
-	page
-}) => {
-	await page.bringToFront();
-
-	await page.goto('/tutorial/layouts');
-
-	const iframe = page.frameLocator(iframe_selector);
-
-	// wait for the iframe to load
-	await iframe.getByText('this is the home page.').waitFor();
-
-	// first, focus the editor
-	await page.locator(editor_selector).click({ delay: 1000 });
-	await expect(page.locator(editor_focus_selector)).toBeFocused();
-
-	// then, click a link in the iframe
-	await iframe.locator('a[href="/about"]').click({ delay: 500 });
-
-	// wait for navigation
-	await iframe.getByText('this is the about page.').waitFor();
-
-	// wait a little, because there may be a script that manipulates focus
-	await page.waitForTimeout(1000);
-
-	// expect focus to be on body in the iframe, not the editor.
-	await expect(iframe.locator('body')).toBeFocused();
+	await expect(page.locator(editor_selector)).not.toBeFocused();
 });
 
 test('focus management: The editor keeps focus while typing', async ({ page }) => {
@@ -92,11 +65,13 @@ test('focus management: The editor keeps focus while typing', async ({ page }) =
 
 	// first, write script tag
 	const code = '<script>\n\n</script>\n';
-	await page.locator(editor_focus_selector).fill(code);
+	await page.locator(editor_selector).fill(code);
 
 	// move the cursor into the script tag
-	await page.keyboard.press('PageUp', { delay: 500 });
-	await page.keyboard.press('ArrowDown', { delay: 500 });
+	await page.waitForTimeout(500);
+	await page.keyboard.press('PageUp');
+	await page.waitForTimeout(500);
+	await page.keyboard.press('ArrowDown');
 
 	// wait a little because the above operation is flaky
 	await page.waitForTimeout(500);