Bug #27212129 [ERROR] INNODB: A RECORD LOCK WAIT HAPPENS IN A DICTIONARY

OPERATION. INDEX `ID_

PROBLEM

This bug is a regression of bug#26390658. When two transactions try to
do alter table partition by (and are trying to do rename table
essentially),one of the transactions ends up in a lock wait trying to
take a lock on record of innodb stats table as the other is holding a
lock on the same record of the stats table as this transaction hasn't
committed yet. A situation like this where in a transaction is made to
wait for record lock of system table and is dictionary operation, innodb
crashes the server.The problem is that the transaction that is done with
rename table and is holding onto record locks that can be released is
not able to do so because it is not yet committed .Therefore causing the
lock wait and crash.

FIX

Solution is to let all the partitions rename to finish and commit
transaction, then proceed with updating of stats table after rename.

Reviewed by: bin su <[email protected]>
RB: 18205

(cherry picked from commit 3b9ab1b0a3bd24151e74e73bcdfb098b969ca747)

Author: Aakanksha Verma

storage/innobase/dict/dict0stats.cc

@@ -3645,6 +3645,13 @@ dict_stats_rename_table(
 		if (ret == DB_STATS_DO_NOT_EXIST) {
 			ret = DB_SUCCESS;
 		}
+		DBUG_EXECUTE_IF("rename_stats",
+				mutex_exit(&dict_sys->mutex);
+				rw_lock_x_unlock(dict_operation_lock);
+				os_thread_sleep(20000000);
+				DEBUG_SYNC_C("rename_stats");
+				rw_lock_x_lock(dict_operation_lock);
+				mutex_enter(&dict_sys->mutex););
 
 		if (ret != DB_SUCCESS) {
 			mutex_exit(&dict_sys->mutex);

storage/innobase/row/row0mysql.cc

@@ -31,6 +31,7 @@ Created 9/17/2000 Heikki Tuuri
 #include <log.h>
 #include <mysys_err.h>
 #include <sql_error.h>
+#include <vector>
 
 #include "row0mysql.h"
 
@@ -5327,6 +5328,7 @@ row_rename_table_for_mysql(
 	pars_info_add_str_literal(info, "new_table_name", new_name);
 	pars_info_add_str_literal(info, "old_table_name", old_name);
 
+	DEBUG_SYNC_C("rename_table");
 	err = que_eval_sql(info,
 			   "PROCEDURE RENAME_TABLE () IS\n"
 			   "BEGIN\n"
@@ -5697,6 +5699,10 @@ row_rename_partitions_for_mysql(
 	memcpy(from_name, old_name, from_len);
 	from_name[from_len] = '#';
 	from_name[from_len + 1] = 0;
+	typedef std::vector<std::pair<std::string, std::string> > partition_names;
+	partition_names store_name;
+	partition_names::iterator it;
+
 	while ((table_name = dict_get_first_table_name_in_db(from_name))) {
 		ut_a(memcmp(table_name, from_name, from_len) == 0);
 		/* Must match #[Pp]#<partition_name> */
@@ -5716,16 +5722,12 @@ row_rename_partitions_for_mysql(
 		error = row_rename_table_for_mysql(table_name, to_name,
 						trx, false);
 		if (error == DB_SUCCESS) {
-			char    errstr[512];
-			error = dict_stats_rename_table(true, table_name, to_name,
-                                              errstr, sizeof(errstr));
-			if (error != DB_SUCCESS) {
-				ib::error() << errstr;
-				push_warning(thd, Sql_condition::SL_WARNING,
-                                     ER_LOCK_WAIT_TIMEOUT, errstr);
-			}
-		}
-		if (error != DB_SUCCESS) {
+			std::pair<std::string, std::string> pair_names;
+			pair_names.first = table_name;
+			pair_names.second = to_name;
+			store_name.push_back(pair_names);
+		} else {
+			store_name.clear();
 			/* Rollback and return. */
 			trx_rollback_for_mysql(trx);
 			ut_free(table_name);
@@ -5734,6 +5736,22 @@ row_rename_partitions_for_mysql(
 		ut_free(table_name);
 	}
 	trx_commit_for_mysql(trx);
+
+	char    errstr[512];
+	for (it = store_name.begin(); it != store_name.end(); ++it) {
+		error = dict_stats_rename_table(
+			   true, it->first.c_str(), it->second.c_str(),
+			   errstr, sizeof(errstr));
+
+		if (error != DB_SUCCESS) {
+			ib::error() << errstr;
+			push_warning(thd, Sql_condition::SL_WARNING,
+				     ER_LOCK_WAIT_TIMEOUT, errstr);
+			break;
+		}
+	}
+
+	store_name.clear();
 	return(error);
 }