BUG#32288105: MYSQL CRASHES IMMEDIATELY AFTER SELECTING FROM

Tor Didriksen · dahlerlend · commit 66bd23f8c0c0 · 2025-03-15T15:58:15.000+01:00
INFORMATION_SCHEMA

Post-push fix for ASAN failure:
==117066==ERROR: AddressSanitizer: stack-use-after-scope on address ..

Move tmp_name out to a scope where it is still alive when used later.

Change-Id: Ic87b9808d0e2d0dec3a7437109516b67940150b2
diff --git a/storage/innobase/dict/dict0dd.cc b/storage/innobase/dict/dict0dd.cc
@@ -443,6 +443,7 @@ int dd_table_open_on_dd_obj(THD *thd, dd::cache::Dictionary_client *client,
   }
 
   const char *table_name = tbl_name;
+  char tmp_name[FN_REFLEN + 1];
   if (!tbl_name) {
     dd::Schema *schema;
     error = client->acquire_uncached<dd::Schema>(dd_table.schema_id(), &schema);
@@ -451,7 +452,6 @@ int dd_table_open_on_dd_obj(THD *thd, dd::cache::Dictionary_client *client,
     }
 
     bool truncated;
-    char tmp_name[FN_REFLEN + 1];
     build_table_filename(tmp_name, sizeof(tmp_name) - 1, schema->name().c_str(),
                          dd_table.name().c_str(), nullptr, 0, &truncated);
 

Original file line number	Diff line number	Diff line change
`@@ -443,6 +443,7 @@ int dd_table_open_on_dd_obj(THD thd, dd::cache::Dictionary_client client,`
`443`	`443`	`}`
`444`	`444`
`445`	`445`	`const char *table_name = tbl_name;`
	`446`	`+ char tmp_name[FN_REFLEN + 1];`
`446`	`447`	`if (!tbl_name) {`
`447`	`448`	`dd::Schema *schema;`
`448`	`449`	`error = client->acquire_uncached<dd::Schema>(dd_table.schema_id(), &schema);`
`@@ -451,7 +452,6 @@ int dd_table_open_on_dd_obj(THD thd, dd::cache::Dictionary_client client,`
`451`	`452`	`}`
`452`	`453`
`453`	`454`	`bool truncated;`
`454`		`- char tmp_name[FN_REFLEN + 1];`
`455`	`455`	`build_table_filename(tmp_name, sizeof(tmp_name) - 1, schema->name().c_str(),`
`456`	`456`	`dd_table.name().c_str(), nullptr, 0, &truncated);`
`457`	`457`