Bug#35308309 : Prepare exec invalid variable assertion error

Description:
------------
Server exits abruptly when we try to set the read
only variable INNODB_PURGE_THREADS.

Analysis:
---------
While setting a read-only variable using the SET
command, mysqld checks if the variable is read
only and then errors out with a proper error
message. This is missing when we set the same read
only variable using PREPARED STATEMENTS. So, the
INNODB_PURGE_THREADS is successfully modified and
it leads to this unexpected behaviour.

Fix:
----
Added the check to error out from setting the read
only variables when it is from PREPARED STATEMENT.

Change-Id: I4a41ab4ae42d6e5867ef383671e9444cb044da8f

Author: Sai Tharun Ambati

sql/set_var.cc

@@ -1667,6 +1667,19 @@ int set_var::check(THD *thd) {
   }
 
   auto f = [this, thd](const System_variable_tracker &, sys_var *var) -> int {
+    if (var->is_readonly()) {
+      if (type != OPT_PERSIST_ONLY) {
+        my_error(ER_INCORRECT_GLOBAL_LOCAL_VAR, MYF(0), var->name.str,
+                 "read only");
+        return -1;
+      }
+      if (type == OPT_PERSIST_ONLY && var->is_non_persistent() &&
+          !can_persist_non_persistent_var(thd, var, type)) {
+        my_error(ER_INCORRECT_GLOBAL_LOCAL_VAR, MYF(0), var->name.str,
+                 "non persistent read only");
+        return -1;
+      }
+    }
     if (var->check_update_type(value->result_type())) {
       my_error(ER_WRONG_TYPE_FOR_VAR, MYF(0), var->name.str);
       return -1;