Fix OCI's manifest tests

Previously, it was not possible to create a file representation of a
file which was missing in the manifest. With this change, this is now
possible, error about non-existing file is delayed until the file is
actually read.

Change-Id: I6193bc3bd3e95898f1c97d574b9cf70fb1deb9d4
(cherry picked from commit 9978204ef84b99765b2355a26e37973ea3476a6b)

Author: Paweł Andruszkiewicz

modules/util/dump/dump_manifest.cc

@@ -225,13 +225,20 @@ class Http_manifest_object : public mysqlshdk::storage::backend::Http_object {
   std::string m_full_name;
 };
 
+mysqlshdk::Masked_string get_full_path(
+    const std::shared_ptr<Manifest_reader> &reader,
+    const Dump_manifest_read_config_ptr &config, const std::string &full_name) {
+  return reader->has_object(full_name)
+             ? mysqlshdk::oci::anonymize_par(
+                   config->par().endpoint() +
+                   reader->get_object(full_name).name())
+             : config->par().endpoint() + full_name;
+}
+
 Http_manifest_object::Http_manifest_object(
     const std::shared_ptr<Manifest_reader> &reader,
     const Dump_manifest_read_config_ptr &config, const std::string &full_name)
-    : Http_object(
-          mysqlshdk::oci::anonymize_par(config->par().endpoint() +
-                                        reader->get_object(full_name).name()),
-          true),
+    : Http_object(get_full_path(reader, config, full_name), true),
       m_reader(reader),
       m_config(config),
       m_full_name(full_name) {}
@@ -246,6 +253,13 @@ bool Http_manifest_object::exists() const {
   if (!exists && !m_reader->is_complete()) {
     m_reader->reload();
     exists = m_reader->has_object(m_full_name);
+
+    // exists() is called when opening the file, if this file didn't exist
+    // before, we need to update its full path now
+    if (exists) {
+      const_cast<Http_manifest_object *>(this)->set_full_path(
+          get_full_path(m_reader, m_config, m_full_name));
+    }
   }
 
   return exists;

mysqlshdk/libs/storage/backend/http.cc

@@ -342,6 +342,11 @@ std::optional<rest::Response_error> Http_object::fetch_file_size() const {
   return {};
 }
 
+void Http_object::set_full_path(const Masked_string &full_path) {
+  m_base = get_uri_base(full_path);
+  m_path = get_uri_path(full_path);
+}
+
 void Http_directory::init_rest(const Masked_string &url) { m_url = url; }
 
 bool Http_directory::exists() const {

mysqlshdk/libs/storage/backend/http.h

@@ -117,6 +117,8 @@ class Http_object : public IFile {
 
   std::optional<rest::Response_error> fetch_file_size() const;
 
+  void set_full_path(const Masked_string &full_path);
+
   off64_t m_offset = 0;
   Masked_string m_base;
   std::string m_path;

unittest/modules/util/dump/dump_manifest_t.cc

@@ -301,7 +301,10 @@ TEST_F(Oci_os_tests, dump_manifest_read_mode) {
       "@.load.progress.json");
   const auto progress_file_uri =
       write_config->service_endpoint() + rw_par.access_uri;
-  EXPECT_THROW_LIKE(read_manifest.file(progress_file_uri), shcore::Exception,
+  const auto missing_file = read_manifest.file(progress_file_uri);
+  EXPECT_FALSE(missing_file->exists());
+  missing_file->open(mysqlshdk::storage::Mode::READ);
+  EXPECT_THROW_LIKE(missing_file->read(buffer, 1), shcore::Exception,
                     "Unknown object in manifest");
 }