BUG#35304391 MySQL Shell detect/warm case sensitivity

Dump loader did not warn if any rows were replaced during the load, this
is now fixed.

Change-Id: Ie580e8097813b4f40a8aee1924463836cac3f8d9
(cherry picked from commit 857fcd2ce3dba380525c4952dfdb541e76bf8383)

Author: Paweł Andruszkiewicz

modules/util/load/dump_loader.cc

@@ -870,6 +870,7 @@ void Dump_loader::Worker::Load_chunk_task::load(
 
   loader->m_num_chunks_loaded += 1;
   loader->m_num_rows_loaded += rows_loaded;
+  loader->m_num_rows_deleted += stats.total_deleted;
   loader->m_num_warnings += stats.total_warnings;
 }
 
@@ -1957,6 +1958,12 @@ void Dump_loader::show_summary() {
             .c_str()));
   }
 
+  if (m_num_rows_deleted > 0) {
+    // BUG#35304391 - notify about replaced rows
+    console->print_info(std::to_string(m_num_rows_deleted) +
+                        " rows were replaced");
+  }
+
   if (m_options.load_users()) {
     std::string msg =
         std::to_string(m_loaded_accounts) + " accounts were loaded";

modules/util/load/dump_loader.h

@@ -589,6 +589,7 @@ class Dump_loader {
 
   size_t m_num_bytes_previously_loaded = 0;
   std::atomic<size_t> m_num_rows_loaded;
+  std::atomic<size_t> m_num_rows_deleted = 0;
   std::atomic<size_t> m_num_bytes_loaded;
   std::atomic<size_t> m_num_raw_bytes_loaded;
   std::atomic<size_t> m_num_chunks_loaded;

unittest/scripts/auto/py_shell/scripts/util_dump_and_load_norecord.py

@@ -2725,6 +2725,42 @@ def TEST_STRING_OPTION(option):
 shell.connect(__sandbox_uri2)
 dba.drop_metadata_schema({ 'force': True })
 
+#@<> BUG#35304391 - loader should notify if rows were replaced during load
+# constants
+dump_dir = os.path.join(outdir, "bug_35304391")
+tested_schema = "tested_schema"
+tested_table = "tested_table"
+
+# setup
+shell.connect(__sandbox_uri1)
+session.run_sql("DROP SCHEMA IF EXISTS !", [ tested_schema ])
+session.run_sql("CREATE SCHEMA ! DEFAULT CHARACTER SET latin1 COLLATE latin1_general_cs", [ tested_schema ])
+session.run_sql("CREATE TABLE !.! (id tinyint AUTO_INCREMENT PRIMARY KEY, alias varchar(12) NOT NULL UNIQUE KEY, name varchar(32) NOT NULL)", [ tested_schema, tested_table ])
+session.run_sql("INSERT INTO !.! (alias, name) VALUES ('bond-007', 'James Bond'), ('Bond-007', 'James Bond')", [ tested_schema, tested_table ])
+
+# dump
+shell.connect(__sandbox_uri1)
+EXPECT_NO_THROWS(lambda: util.dump_instance(dump_dir, { "includeSchemas": [ tested_schema ], "showProgress": False }), "Dump should not fail")
+
+# load
+shell.connect(__sandbox_uri2)
+wipeout_server(session)
+# load just the DDL
+EXPECT_NO_THROWS(lambda: util.load_dump(dump_dir, { "loadData": False, "resetProgress": True, "showProgress": False }), "Load should not fail")
+# change collation to case-insensitive
+session.run_sql("ALTER SCHEMA ! CHARACTER SET latin1 COLLATE latin1_general_ci", [ tested_schema ])
+session.run_sql("ALTER TABLE !.! CONVERT TO CHARACTER SET latin1 COLLATE latin1_general_ci", [ tested_schema, tested_table ])
+# load the data
+WIPE_OUTPUT()
+EXPECT_NO_THROWS(lambda: util.load_dump(dump_dir, { "loadDdl": False, "resetProgress": True, "showProgress": False }), "Load should not fail")
+
+# verification
+EXPECT_STDOUT_CONTAINS("1 rows were replaced")
+
+#@<> BUG#35304391 - cleanup
+shell.connect(__sandbox_uri1)
+session.run_sql("DROP SCHEMA IF EXISTS !", [tested_schema])
+
 #@<> Cleanup
 testutil.destroy_sandbox(__mysql_sandbox_port1)
 testutil.destroy_sandbox(__mysql_sandbox_port2)