BUG#36004885 BUG#36004919 Align check name in WL and implementation and Don't link mysqlserverteam.com

This commit fixes bug with aligning check names with WL description.
It also fixes links that pointed to non-functional "mysqlserverteam.com" site, and replaces them to equivalent pages on dev.mysql.com.

Change-Id: I41c1f20e8cc20ed68f74fb0ec26083e932baa671

Author: Marek Młynarski

modules/util/upgrade_check.cc

@@ -2073,7 +2073,7 @@ class Deprecated_auth_method_check : public Sql_upgrade_check {
  public:
   Deprecated_auth_method_check(mysqlshdk::utils::Version target_ver)
       : Sql_upgrade_check(
-            "mysqlDeprecatedAuthMethodCheck",
+            "deprecatedAuthMethod",
             "Check for deprecated or invalid user authentication methods.",
             std::vector<std::string>{
                 "SELECT CONCAT(user, '@', host), plugin FROM "
@@ -2105,7 +2105,7 @@ class Deprecated_auth_method_check : public Sql_upgrade_check {
 Deprecated_default_auth_check::Deprecated_default_auth_check(
     mysqlshdk::utils::Version target_ver)
     : Sql_upgrade_check(
-          "mysqlDeprecatedDefaultAuthCheck",
+          "deprecatedDefaultAuth",
           "Check for deprecated or invalid default authentication methods in "
           "system variables.",
           std::vector<std::string>{

res/upgrade_checker/upgrade_checker.msg

@@ -42,7 +42,7 @@
 # the table using 'ALTER TABLE <table_name> FORCE' command
 
 * oldTemporalCheck.docLink
-https://mysqlserverteam.com/mysql-8-0-removing-support-for-old-temporal-datatypes/
+https://dev.mysql.com/blog-archive/mysql-8-0-removing-support-for-old-temporal-datatypes/
 
 * routinesSyntaxCheck.title
 # MySQL 8.0 syntax check for routine-like objects
@@ -222,7 +222,7 @@ https://dev.mysql.com/doc/refman/8.0/en/added-deprecated-removed.html#optvars-re
 # performing upgrade.
 
 * sysVarsNewDefaults.docLink
-https://mysqlserverteam.com/new-defaults-in-mysql-8-0/
+https://dev.mysql.com/blog-archive/new-defaults-in-mysql-8-0/
 
 * zeroDatesCheck.title
 # Zero Date, Datetime, and Timestamp values

unittest/modules/upgrade_check_t.cc

@@ -897,8 +897,9 @@ TEST_F(MySQL_upgrade_check_test, sys_vars_new_defaults) {
 
   std::unique_ptr<Upgrade_check> check =
       Sql_upgrade_check::get_sys_vars_new_defaults_check();
-  EXPECT_EQ(0, strcmp("https://mysqlserverteam.com/new-defaults-in-mysql-8-0/",
-                      check->get_doc_link()));
+  EXPECT_EQ(
+      0, strcmp("https://dev.mysql.com/blog-archive/new-defaults-in-mysql-8-0/",
+                check->get_doc_link()));
 
   EXPECT_THROW_LIKE(
       check->run(session, info), Upgrade_check::Check_configuration_error,
@@ -1885,11 +1886,9 @@ TEST_F(MySQL_upgrade_check_test, deprecated_auth_method_json_check) {
       ASSERT_TRUE(check.IsObject());
       ASSERT_TRUE(check.HasMember("id"));
       ASSERT_TRUE(check["id"].IsString());
-      if (std::string(check["id"].GetString()) ==
-          "mysqlDeprecatedAuthMethodCheck")
+      if (std::string(check["id"].GetString()) == "deprecatedAuthMethod")
         found_dep_auth_check_id = true;
-      if (std::string(check["id"].GetString()) ==
-          "mysqlDeprecatedDefaultAuthCheck")
+      if (std::string(check["id"].GetString()) == "deprecatedDefaultAuth")
         found_def_auth_check_id = true;
     }
     EXPECT_TRUE(found_dep_auth_check_id);