Fix source_retry_count default check

Whenever shell is adopting an unmanaged replication topology to a
ReplicaSet, it checks some variables for default values. The 8.1.0
release of MySQL server changed the default of SOURCE_RETRY_COUNT to 10.

This patch updates the Shell default value of that variable for that
server version (or newer).

Change-Id: Ic81c018e3911ea305291e1a1ef52d87405098f9f

Author: joaosigma

modules/adminapi/common/star_global_topology_manager.cc

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019, 2022, Oracle and/or its affiliates.
+ * Copyright (c) 2019, 2023, Oracle and/or its affiliates.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -131,10 +131,12 @@ void validate_unsupported_options(
   }
 
   constexpr auto k_default_connect_retry = 60;
-  constexpr auto k_default_retry_count = 86400;
   constexpr auto k_default_heartbeat_period = 30;
   constexpr auto k_default_compression_algorithm = "uncompressed";
 
+  const auto k_default_retry_count =
+      (server_version >= mysqlshdk::utils::Version(8, 1)) ? 10 : 86400;
+
   std::string source_term =
       mysqlshdk::mysql::get_replication_source_keyword(server_version);
 

unittest/scripts/auto/js_adminapi_async/validation/add_instance.js

@@ -236,7 +236,7 @@
 |                    SQL_Delay: 0|
 |          SQL_Remaining_Delay: NULL|
 |      Slave_SQL_Running_State: <<<__replica_keyword_capital>>> has read all relay log; waiting for more updates|
-|           Master_Retry_Count: 86400|
+|           Master_Retry_Count: <<<(__version_num<80100)?86400:10>>>|
 |                  Master_Bind: |
 |      Last_IO_Error_Timestamp: |
 |     Last_SQL_Error_Timestamp: |

unittest/scripts/auto/js_adminapi_async/validation/status.js

@@ -127,7 +127,7 @@
                         "connectRetry": 60,
                         "delay": 0,
                         "heartbeatPeriod": 30,
-                        "retryCount": 86400
+                        "retryCount": <<<(__version_num<80100)?86400:10>>>
                     },
                     "receiverStatus": "ON",
                     "receiverThreadState": "Waiting for <<<__source_keyword>>> to send event",
@@ -219,7 +219,7 @@
                         "connectRetry": 60,
                         "delay": 0,
                         "heartbeatPeriod": 123,
-                        "retryCount": 86400
+                        "retryCount": <<<(__version_num<80100)?86400:10>>>
                     },
                     "receiverStatus": "ON",
                     "receiverThreadState": "Waiting for <<<__source_keyword>>> to send event",