BUG#25966731 : ALLOW-NON-COMPATIBLE-TABLES OPTION DOES NOT EXIST

When adding nodes to a InnoDB Cluster using the appropriate AdminAPI
operations, some checks are performed to verify the compatibility of the
existing tables. If incompatible tables (e.g., MyISAM tables) are detected
then an error is issued, however a message is logged referring an option
not available for the AdminAPI operations: --allow-non-compatible-tables.
This option is from mysqlprovision (internal tool) and should not be
displayed to users.

This patch fix this issue by removing the logged message including the option
from mysqlprovision.

New unit tests were added for regression.

Author: Paulo Jesus

python/mysql_gadgets/common/group_replication.py

@@ -1004,7 +1004,6 @@ def check_compliance(req_checker, error_msgs=None):
             if bad_engine or bad_pk:
                 error_msgs.append("Non-compatible tables found in database.")
                 _LOGGER.info(INNODB_RQD_MSG)
-                _LOGGER.info(SKIP_SCHEMA_MSG)
                 _LOGGER.info("")
 
 

unittest/scripts/js_devapi/scripts/dba_cluster_misconfigurations.js

@@ -42,6 +42,18 @@ session.runSql('SET sql_log_bin=1');
 // Regression for BUG#25974689 : CHECKS ARE MORE STRICT THAN GROUP REPLICATION
 var cluster = dba.createCluster('dev');
 
+//@ Enable verbose
+// Regression for BUG#25966731 : ALLOW-NON-COMPATIBLE-TABLES OPTION DOES NOT EXIST
+dba.verbose = 1;
+
+//@<ERR> Create cluster fails (one table is not compatible) - verbose mode
+// Regression for BUG#25966731 : ALLOW-NON-COMPATIBLE-TABLES OPTION DOES NOT EXIST
+var cluster = dba.createCluster('dev');
+
+//@ Disable verbose
+// Regression for BUG#25966731 : ALLOW-NON-COMPATIBLE-TABLES OPTION DOES NOT EXIST
+dba.verbose = 0;
+
 // Clean-up test schema with PK, PKE, and UK
 // Regression for BUG#25974689 : CHECKS ARE MORE STRICT THAN GROUP REPLICATION
 session.runSql('SET sql_log_bin=0');

unittest/scripts/js_devapi/validation/dba_cluster_misconfigurations.js

@@ -10,6 +10,24 @@
 //@ Create cluster fails (one table is not compatible)
 ||Dba.createCluster: ERROR: 1 table(s) do not have a Primary Key or Primary Key Equivalent (non-null unique key).
 
+//@ Enable verbose
+||
+
+//@<ERR> Create cluster fails (one table is not compatible) - verbose mode
+* Checking compliance of existing tables... FAIL
+ERROR: 1 table(s) do not have a Primary Key or Primary Key Equivalent (non-null unique key).
+	pke_test.t3
+
+Group Replication requires tables to use InnoDB and have a PRIMARY KEY or PRIMARY KEY Equivalent (non-null unique key). Tables that do not follow these requirements will be readable but not updateable when used with Group Replication. If your applications make updates (INSERT, UPDATE or DELETE) to these tables, ensure they use the InnoDB storage engine and have a PRIMARY KEY or PRIMARY KEY Equivalent.
+
+
+ERROR: Error starting cluster: The operation could not continue due to the following requirements not being met:
+Non-compatible tables found in database.
+==============================================================================
+
+//@ Disable verbose
+||
+
 //@ Create cluster succeeds (no incompatible table)
 ||
 

unittest/scripts/py_devapi/scripts/dba_cluster_misconfigurations.py

@@ -42,6 +42,18 @@
 # Regression for BUG#25974689 : CHECKS ARE MORE STRICT THAN GROUP REPLICATION
 cluster = dba.create_cluster('dev')
 
+#@ Enable verbose
+# Regression for BUG#25966731 : ALLOW-NON-COMPATIBLE-TABLES OPTION DOES NOT EXIST
+dba.verbose = 1
+
+#@<ERR> Create cluster fails (one table is not compatible) - verbose mode
+# Regression for BUG#25966731 : ALLOW-NON-COMPATIBLE-TABLES OPTION DOES NOT EXIST
+cluster = dba.create_cluster('dev')
+
+#@ Disable verbose
+# Regression for BUG#25966731 : ALLOW-NON-COMPATIBLE-TABLES OPTION DOES NOT EXIST
+dba.verbose = 0
+
 # Clean-up test schema with PK, PKE, and UK
 # Regression for BUG#25974689 : CHECKS ARE MORE STRICT THAN GROUP REPLICATION
 session.run_sql('SET sql_log_bin=0')

unittest/scripts/py_devapi/validation/dba_cluster_misconfigurations.py

@@ -10,6 +10,24 @@
 #@ Create cluster fails (one table is not compatible)
 ||SystemError: RuntimeError: Dba.create_cluster: ERROR: 1 table(s) do not have a Primary Key or Primary Key Equivalent (non-null unique key).
 
+#@ Enable verbose
+||
+
+#@<ERR> Create cluster fails (one table is not compatible) - verbose mode
+* Checking compliance of existing tables... FAIL
+ERROR: 1 table(s) do not have a Primary Key or Primary Key Equivalent (non-null unique key).
+	pke_test.t3
+
+Group Replication requires tables to use InnoDB and have a PRIMARY KEY or PRIMARY KEY Equivalent (non-null unique key). Tables that do not follow these requirements will be readable but not updateable when used with Group Replication. If your applications make updates (INSERT, UPDATE or DELETE) to these tables, ensure they use the InnoDB storage engine and have a PRIMARY KEY or PRIMARY KEY Equivalent.
+
+
+ERROR: Error starting cluster: The operation could not continue due to the following requirements not being met:
+Non-compatible tables found in database.
+==============================================================================
+
+#@ Disable verbose
+||
+
 #@ Create cluster succeeds (no incompatible table)
 ||