Skip to content

Commit f0d95af

Browse files
author
Paweł Andruszkiewicz
committed
Add more information to the verbose version string
Added information about product ID (OS and package type). Change-Id: Ifc1aa0c49bcb875351af3333d854613752fd97d5
1 parent ca24637 commit f0d95af

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

src/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ if(WIN32)
9090
endif()
9191

9292
add_definitions(-DMYSH_COMMIT_ID="${MYSH_COMMIT_ID}")
93+
add_definitions(-DMYSH_PRODUCT_ID="${MYSH_PRODUCT_ID}")
9394

9495
add_shell_executable(mysqlsh "${mysqlsh_SRC}")
9596
ADD_STAN_TARGET(mysqlsh mysqlsh/main.cc)

src/mysqlsh/main.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -530,6 +530,11 @@ static std::string version_string(const char *argv0, bool extra) {
530530
version_msg.append(" - commit_id ");
531531
version_msg.append(MYSH_COMMIT_ID);
532532
}
533+
534+
if (*MYSH_PRODUCT_ID) {
535+
version_msg.append(" - product_id ");
536+
version_msg.append(MYSH_PRODUCT_ID);
537+
}
533538
} else {
534539
snprintf(&version_msg[0], version_msg.size(), "%s %s", argv0,
535540
shcore::get_long_version());

version.cmake

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,18 @@ GET_MYSQL_VERSION()
115115

116116
SET(MYSH_BUILD_ID "$ENV{PARENT_ID}")
117117
SET(MYSH_COMMIT_ID "$ENV{PUSH_REVISION}")
118+
SET(MYSH_PRODUCT_ID "$ENV{PRODUCT_ID}")
119+
120+
IF(MYSH_PRODUCT_ID)
121+
STRING(REPLACE "_" ";" MYSH_PRODUCT_ID_LIST "${MYSH_PRODUCT_ID}")
122+
LIST(LENGTH MYSH_PRODUCT_ID_LIST MYSH_PRODUCT_ID_LIST_LEN)
123+
124+
IF(MYSH_PRODUCT_ID_LIST_LEN GREATER_EQUAL 2)
125+
LIST(GET MYSH_PRODUCT_ID_LIST -2 MYSH_PRODUCT_OS)
126+
LIST(GET MYSH_PRODUCT_ID_LIST -1 MYSH_PRODUCT_PACKAGE)
127+
SET(MYSH_PRODUCT_ID "${MYSH_PRODUCT_OS} ${MYSH_PRODUCT_PACKAGE}")
128+
ENDIF()
129+
ENDIF()
118130

119131
# On Windows, AssemblyVersion does not allow slashes. Example: 1.0.5-labs
120132
IF(WIN32)

0 commit comments

Comments
 (0)