CR feedback, also add $parameters to docblock for Repositories

Author: Daniel André Eikeland

lib/Gitlab/Api/Deployments.php

@@ -4,11 +4,13 @@ class Deployments extends AbstractApi
 {
     /**
      * @param int $project_id
+     * @param array $parameters
      * @return mixed
      */
-    public function all($project_id)
+    public function all($project_id, array $parameters = [])
     {
-        return $this->get($this->getProjectPath($project_id, 'deployments'));
+        $resolver = $this->createOptionsResolver();
+        return $this->get($this->getProjectPath($project_id, 'deployments'), $resolver->resolve($parameters));
     }
 
     /**

lib/Gitlab/Api/Environments.php

@@ -6,25 +6,30 @@ class Environments extends AbstractApi
 {
     /**
      * @param int $project_id
+     * @param array $parameters
      * @return mixed
      */
-    public function all($project_id)
+    public function all($project_id, array $parameters = [])
     {
-        return $this->get($this->getProjectPath($project_id, 'environments'));
+        $resolver = $this->createOptionsResolver();
+        return $this->get($this->getProjectPath($project_id, 'environments'), $resolver->resolve($parameters));
     }
 
     /**
      * @param int $project_id
-     * @param array $parameters
+     * @param array $parameters (
+     *
+     *     @var string $name         The name of the environment
+     *     @var string $external_url Place to link to for this environment
+     * )
      * @return mixed
      */
     public function create($project_id, array $parameters = array())
     {
         $resolver = new OptionsResolver();
         $resolver->setDefined('name')
+	        ->setRequired('name')
             ->setAllowedTypes('name', 'string');
-        $resolver->setDefined('slug')
-            ->setAllowedTypes('slug', 'string');
         $resolver->setDefined('external_url')
             ->setAllowedTypes('external_url', 'string');
 

lib/Gitlab/Api/Repositories.php

@@ -6,6 +6,7 @@ class Repositories extends AbstractApi
 {
     /**
      * @param int $project_id
+     * @param array $parameters
      * @return mixed
      */
     public function branches($project_id, array $parameters = [])