Skip to content

Commit c7052bb

Browse files
committed
fix: HTML report makes room for 4-digit line numbers #1124
Fixes: #1124
1 parent dc9b842 commit c7052bb

File tree

4 files changed

+17
-13
lines changed

4 files changed

+17
-13
lines changed

CHANGES.rst

+4
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,12 @@ Unreleased
2929
they have been combined. This was requested in `issue 1108`_ and implemented
3030
in `pull request 1110`_. Thanks, Éric Larivière.
3131

32+
- The HTML report has a little more room for line numbers so that 4-digit
33+
numbers work well, fixing `issue 1124`_.
34+
3235
.. _issue 1108: https://github.com/nedbat/coveragepy/issues/1108
3336
.. _pull request 1110: https://github.com/nedbat/coveragepy/pull/1110
37+
.. _issue 1124: https://github.com/nedbat/coveragepy/issues/1124
3438

3539
.. _changes_54:
3640

coverage/htmlfiles/style.css

+5-5
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ a.nav:hover { text-decoration: underline; color: inherit; }
3434

3535
@media (prefers-color-scheme: dark) { #header { border-color: #333; } }
3636

37-
.indexfile #footer { margin: 1rem 3rem; }
37+
.indexfile #footer { margin: 1rem 3.5rem; }
3838

3939
.pyfile #footer { margin: 1rem 1rem; }
4040

4141
#footer .content { padding: 0; color: #666; font-style: italic; }
4242

4343
@media (prefers-color-scheme: dark) { #footer .content { color: #aaa; } }
4444

45-
#index { margin: 1rem 0 0 3rem; }
45+
#index { margin: 1rem 0 0 3.5rem; }
4646

47-
#header .content { padding: 1rem 3rem; }
47+
#header .content { padding: 1rem 3.5rem; }
4848

4949
h1 { font-size: 1.25em; display: inline-block; }
5050

@@ -122,13 +122,13 @@ h2.stats { margin-top: .5em; font-size: 1em; }
122122

123123
.keyhelp .key { border: 1px solid black; border-color: #888 #333 #333 #888; padding: .1em .35em; font-family: SFMono-Regular, Menlo, Monaco, Consolas, monospace; font-weight: bold; background: #eee; }
124124

125-
#source { padding: 1em 0 1em 3rem; font-family: SFMono-Regular, Menlo, Monaco, Consolas, monospace; }
125+
#source { padding: 1em 0 1em 3.5rem; font-family: SFMono-Regular, Menlo, Monaco, Consolas, monospace; }
126126

127127
#source p { position: relative; white-space: pre; }
128128

129129
#source p * { box-sizing: border-box; }
130130

131-
#source p .n { float: left; text-align: right; width: 3rem; box-sizing: border-box; margin-left: -3rem; padding-right: 1em; color: #999; }
131+
#source p .n { float: left; text-align: right; width: 3.5rem; box-sizing: border-box; margin-left: -3.5rem; padding-right: 1em; color: #999; }
132132

133133
@media (prefers-color-scheme: dark) { #source p .n { color: #777; } }
134134

coverage/htmlfiles/style.scss

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
/* Don't edit this .css file. Edit the .scss file instead! */
1717

1818
// Dimensions
19-
$left-gutter: 3rem;
19+
$left-gutter: 3.5rem;
2020

2121

2222
//
@@ -166,7 +166,7 @@ a.nav {
166166
}
167167

168168
.indexfile #footer {
169-
margin: 1rem 3rem;
169+
margin: 1rem $left-gutter;
170170
}
171171

172172
.pyfile #footer {
@@ -181,7 +181,7 @@ a.nav {
181181
}
182182

183183
#index {
184-
margin: 1rem 0 0 3rem;
184+
margin: 1rem 0 0 $left-gutter;
185185
}
186186

187187
// Header styles

tests/gold/html/styled/style.css

+5-5
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ a.nav:hover { text-decoration: underline; color: inherit; }
3434

3535
@media (prefers-color-scheme: dark) { #header { border-color: #333; } }
3636

37-
.indexfile #footer { margin: 1rem 3rem; }
37+
.indexfile #footer { margin: 1rem 3.5rem; }
3838

3939
.pyfile #footer { margin: 1rem 1rem; }
4040

4141
#footer .content { padding: 0; color: #666; font-style: italic; }
4242

4343
@media (prefers-color-scheme: dark) { #footer .content { color: #aaa; } }
4444

45-
#index { margin: 1rem 0 0 3rem; }
45+
#index { margin: 1rem 0 0 3.5rem; }
4646

47-
#header .content { padding: 1rem 3rem; }
47+
#header .content { padding: 1rem 3.5rem; }
4848

4949
h1 { font-size: 1.25em; display: inline-block; }
5050

@@ -122,13 +122,13 @@ h2.stats { margin-top: .5em; font-size: 1em; }
122122

123123
.keyhelp .key { border: 1px solid black; border-color: #888 #333 #333 #888; padding: .1em .35em; font-family: SFMono-Regular, Menlo, Monaco, Consolas, monospace; font-weight: bold; background: #eee; }
124124

125-
#source { padding: 1em 0 1em 3rem; font-family: SFMono-Regular, Menlo, Monaco, Consolas, monospace; }
125+
#source { padding: 1em 0 1em 3.5rem; font-family: SFMono-Regular, Menlo, Monaco, Consolas, monospace; }
126126

127127
#source p { position: relative; white-space: pre; }
128128

129129
#source p * { box-sizing: border-box; }
130130

131-
#source p .n { float: left; text-align: right; width: 3rem; box-sizing: border-box; margin-left: -3rem; padding-right: 1em; color: #999; }
131+
#source p .n { float: left; text-align: right; width: 3.5rem; box-sizing: border-box; margin-left: -3.5rem; padding-right: 1em; color: #999; }
132132

133133
@media (prefers-color-scheme: dark) { #source p .n { color: #777; } }
134134

0 commit comments

Comments
 (0)