Skip to content

Commit a39d0f3

Browse files
committed
Add helper macro, Update comment authors
1 parent 58a1ae7 commit a39d0f3

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

phlib/include/phnativeinl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,7 @@ PhGetThreadLastSystemCall(
890890
ThreadHandle,
891891
ThreadLastSystemCall,
892892
LastSystemCall,
893-
RTL_SIZEOF_THROUGH_FIELD(THREAD_LAST_SYSCALL_INFORMATION, Pad), // HACK: Win7 requires exact size.
893+
RTL_SIZEOF_THROUGH_FIELD(THREAD_LAST_SYSCALL_INFORMATION, Pad), // HACK: Win7 requires exact size. (dmex)
894894
NULL
895895
);
896896
}

phlib/include/phsup.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@
4242
#define ASSUME_NO_DEFAULT __assume(FALSE)
4343
#endif
4444

45+
// Math
46+
47+
#define UInt32Add32To64(a, b) ((unsigned __int64)((unsigned __int64)(a) + ((unsigned __int64)(b)))) // Avoids warning C26451 (dmex)
48+
4549
// Time
4650

4751
#define PH_TICKS_PER_NS ((LONG64)1 * 10)

phlib/native.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6021,8 +6021,7 @@ VOID PhpRtlModulesToGenericModules(
60216021
// directory.
60226022
PhGetSystemRoot(&systemRoot);
60236023
newFileName = PhConcatStringRef3(&systemRoot, &driversString, &moduleInfo.Name->sr);
6024-
PhDereferenceObject(moduleInfo.FileName);
6025-
moduleInfo.FileName = newFileName;
6024+
PhMoveReference(&moduleInfo.FileName, newFileName);
60266025
}
60276026

60286027
cont = Callback(&moduleInfo, Context);

phlib/svcsup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ NTSTATUS PhGetServiceDllParameter(
562562
// The SCM creates multiple "user service instance" processes for each user session with the following template:
563563
// [Host Service Instance Name]_[LUID for Session]
564564
// The SCM internally uses the ServiceDll of the "host service instance" for all "user service instance" processes/services
565-
// and we need to parse the user service template and query the "host service instance" configuration.
565+
// and we need to parse the user service template and query the "host service instance" configuration. (hsebs)
566566

567567
if (PhSplitStringRefAtLastChar(ServiceName, L'_', &hostServiceName, &userSessionLuid))
568568
keyName = PhConcatStringRef3(&servicesKeyName, &hostServiceName, &parameters);

0 commit comments

Comments
 (0)