Skip to content

Commit e681ec5

Browse files
FedericoVamueller
authored andcommitted
Removed the use of StringIO, using pickle.dumps instead.
1 parent 940b516 commit e681ec5

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

sklearn/tests/test_common.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import numpy as np
1818
from scipy import sparse
19-
from StringIO import StringIO
2019

2120
from sklearn.utils.testing import assert_raises
2221
from sklearn.utils.testing import assert_equal
@@ -424,10 +423,8 @@ def test_transformers_pickle():
424423

425424
trans.fit(X, y_)
426425
X_pred = trans.fit_transform(X, y=y_)
427-
pickled_trans = StringIO.StringIO()
428-
pickle.dump(trans, pickled_trans)
429-
pickled_trans.pos = 0
430-
unpickled_trans = pickle.load(pickled_trans)
426+
pickled_trans = pickle.dumps(trans)
427+
unpickled_trans = pickle.loads(pickled_trans)
431428
pickled_X_pred = unpickled_trans.fit_transform(X, y=y_)
432429

433430
try:
@@ -671,10 +668,8 @@ def test_classifiers_pickle():
671668
# fit
672669
clf.fit(X, y)
673670
y_pred = clf.predict(X)
674-
pickled_clf = StringIO.StringIO()
675-
pickle.dump(clf, pickled_clf)
676-
pickled_clf.pos = 0
677-
unpickled_clf = pickle.load(pickled_clf)
671+
pickled_clf = pickle.dumps(clf)
672+
unpickled_clf = pickle.loads(pickled_clf)
678673
pickled_y_pred = unpickled_clf.predict(X)
679674

680675
try:
@@ -794,10 +789,8 @@ def test_regressor_pickle():
794789
reg.fit(X, y_)
795790
y_pred = reg.predict(X)
796791
# store old predictions
797-
pickled_reg = StringIO.StringIO()
798-
pickle.dump(reg, pickled_reg)
799-
pickled_reg.pos = 0
800-
unpickled_reg = pickle.load(pickled_reg)
792+
pickled_reg = pickle.dumps(reg)
793+
unpickled_reg = pickle.loads(pickled_reg)
801794
pickled_y_pred = unpickled_reg.predict(X)
802795

803796
try:

0 commit comments

Comments
 (0)