Add rx.attributedText to UITextView and UITextField

Author: carlosypunto

RxCocoa/iOS/UITextField+Rx.swift

@@ -36,6 +36,13 @@ extension Reactive where Base: UITextField {
         )
     }
 
+    /// Bindable sink for `attributedText` property.
+    public var attributedText: UIBindingObserver<Base, NSAttributedString?> {
+        return UIBindingObserver(UIElement: self.base) { textField, attributedText in
+            textField.attributedText = attributedText
+        }
+    }
+    
 }
 
 #endif

RxCocoa/iOS/UITextView+Rx.swift

@@ -53,6 +53,45 @@ extension Reactive where Base: UITextView {
 
         return ControlProperty(values: source, valueSink: bindingObserver)
     }
+    
+    
+    /// Reactive wrapper for `attributedText` property.
+    public var attributedText: ControlProperty<NSAttributedString?> {
+        let source: Observable<NSAttributedString?> = Observable.deferred { [weak textView = self.base] in
+            let attributedText = textView?.attributedText
+            
+            let textChanged: Observable<NSAttributedString?> = textView?.textStorage
+                // This project uses text storage notifications because
+                // that's the only way to catch autocorrect changes
+                // in all cases. Other suggestions are welcome.
+                .rx.didProcessEditingRangeChangeInLength
+                // This observe on is here because attributedText storage
+                // will emit event while process is not completely done,
+                // so rebinding a value will cause an exception to be thrown.
+                .observeOn(MainScheduler.asyncInstance)
+                .map { _ in
+                    guard let textStorage = textView?.textStorage else { return nil }
+                    return textStorage.attributedSubstring(from: NSRange(location: 0, length: textStorage.string.utf8.count))
+                }
+                ?? Observable.empty()
+            
+            return textChanged
+                .startWith(attributedText)
+        }
+        
+        let bindingObserver = UIBindingObserver(UIElement: self.base) { (textView, attributedText: NSAttributedString?) in
+            // This check is important because setting text value always clears control state
+            // including marked text selection which is imporant for proper input
+            // when IME input method is used.
+            if textView.attributedText != attributedText {
+                print(textView.attributedText)
+                print(attributedText)
+                textView.attributedText = attributedText
+            }
+        }
+        
+        return ControlProperty(values: source, valueSink: bindingObserver)
+    }
 
     /// Reactive wrapper for `delegate` message.
     public var didBeginEditing: ControlEvent<()> {

Tests/RxCocoaTests/UITextField+RxTests.swift

@@ -13,35 +13,46 @@ import XCTest
 
 // UITextField
 final class UITextFieldTests : RxTest {
+    
     func test_TextCompletesOnDealloc() {
         ensurePropertyDeallocated({ UITextField() }, "a", comparer: { $0 == $1 }) { (view: UITextField) in view.rx.text }
     }
     func test_ValueCompletesOnDealloc() {
         ensurePropertyDeallocated({ UITextField() }, "a", comparer: { $0 == $1 }) { (view: UITextField) in view.rx.value }
     }
-
+    
     func testSettingTextDoesntClearMarkedText() {
         let textField = UITextFieldSubclass(frame: CGRect.zero)
-
+        
         textField.text = "Text1"
-        textField.set = false
+        textField.settedText = false
         textField.rx.text.on(.next("Text1"))
-        XCTAssertTrue(!textField.set)
+        XCTAssertTrue(!textField.settedText)
         textField.rx.text.on(.next("Text2"))
-        XCTAssertTrue(textField.set)
+        XCTAssertTrue(textField.settedText)
+    }
+    
+    func testLabel_attributedTextObserver() {
+        let label = UILabel()
+        XCTAssertEqual(label.attributedText, nil)
+        let text = NSAttributedString(string: "Hello!")
+        _ = Observable.just(text).bind(to: label.rx.attributedText)
+        
+        XCTAssertEqual(label.attributedText, text)
     }
 }
 
 final class UITextFieldSubclass : UITextField {
-    var set: Bool = false
-
+    var settedText = false
+    
     override var text: String? {
         get {
             return super.text
         }
         set {
-            set = true
+            settedText = true
             super.text = newValue
         }
     }
+    
 }

Tests/RxCocoaTests/UITextView+RxTests.swift

@@ -22,16 +22,32 @@ final class UITextViewTests : RxTest {
         let createView: () -> UITextView = { UITextView(frame: CGRect(x: 0, y: 0, width: 1, height: 1)) }
         ensurePropertyDeallocated(createView, "text", comparer: { $0 == $1 }) { (view: UITextView) in view.rx.value }
     }
-
+    
     func testSettingTextDoesntClearMarkedText() {
         let textView = UITextViewSubclass2(frame: CGRect.zero)
-
+        
         textView.text = "Text1"
-        textView.set = false
+        textView.settedText = false
         textView.rx.text.on(.next("Text1"))
-        XCTAssertTrue(!textView.set)
+        XCTAssertTrue(!textView.settedText)
         textView.rx.text.on(.next("Text2"))
-        XCTAssertTrue(textView.set)
+        XCTAssertTrue(textView.settedText)
+    }
+    
+    func testSettingTextDoesntClearMarkedAttributtedText() {
+        let textView = UITextViewSubclass2(frame: CGRect.zero)
+        
+        let initialAttributedString = NSAttributedString(string: "Test1")
+        let nextAttributedString = NSAttributedString(string: "Test1")
+        
+        textView.attributedText = initialAttributedString
+        let textViewSettedAttributedText = textView.attributedText
+        textView.settedAttributedText = false
+        
+        textView.rx.attributedText.on(.next(textViewSettedAttributedText))
+        XCTAssertTrue(!textView.settedAttributedText)
+        textView.rx.attributedText.on(.next(nextAttributedString))
+        XCTAssertTrue(textView.settedAttributedText)
     }
 
     func testDidBeginEditing() {
@@ -116,15 +132,26 @@ final class UITextViewTests : RxTest {
 }
 
 final class UITextViewSubclass2 : UITextView {
-    var set: Bool = false
-
+    var settedText = false
+    var settedAttributedText = false
+    
     override var text: String? {
         get {
             return super.text
         }
         set {
-            set = true
+            settedText = true
             super.text = newValue
         }
     }
+    
+    override var attributedText: NSAttributedString? {
+        get {
+            return super.attributedText
+        }
+        set {
+            settedAttributedText = true
+            super.attributedText = newValue
+        }
+    }
 }