Re-added 'stop' command that got lost in the refactor

Author: daniel-lundin

src/animation.js

@@ -41,7 +41,6 @@ function createAnimation(startState, endState, options, transformProperty) {
     stop() { stopped = true; },
     endState() { return endState; },
     isStopped() { return stopped; },
-    isStarted() { return started; },
 
     finish(callback) {
       manual = false;
@@ -108,7 +107,7 @@ function createAnimation(startState, endState, options, transformProperty) {
       manualValue = Math.min(Math.max(_manualValue, 0.0001), 1 + manualDelayFactor);
     },
 
-    updateCurrentTransform: function() {
+    updateCurrentTransform() {
       var tweenValue = easer.getValue();
       if (manual) {
         var value = Math.max(0.00001, manualValue - manualDelayFactor);

src/engine.js

@@ -138,6 +138,10 @@ const Engine = {
     var animation;
     if (arg2 === 'attention') {
       animation = this.createAttentionAnimation(element, arg3);
+    } else if (arg2 === 'stop') {
+      return this.runningAnimations = this.runningAnimations.filter((animation) => {
+        return element !== animation[0];
+      });
     } else {
       animation = this.createAnimation(element, arg2);
     }

src/tests/animationTests.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const sinon = require('sinon');
-const chai = require('chai')
+const chai = require('chai');
 const expect = chai.expect;
 chai.use(require('chai-string'));
 const createAnimation = require('../animation.js').createAnimation;
@@ -31,12 +31,10 @@ describe('animations', () => {
       animation.updateCurrentTransform.restore();
     });
 
-    it('should set started and call updateTransform for first tick', () => {
-      expect(animation.isStarted()).to.not.be.ok;
+    it('should call updateTransform for first tick', () => {
       sinon.assert.notCalled(animation.updateCurrentTransform);
 
       animation.tick(100);
-      expect(animation.isStarted()).to.be.ok;
       sinon.assert.calledOnce(animation.updateCurrentTransform);
     });
 

src/tests/engineTests.js

@@ -254,6 +254,15 @@ describe('Engine', () => {
       expect(Engine.runningAnimations).to.have.length(1);
     });
 
+    it('should stop animation with \'stop\' command', () => {
+      const element = {};
+      Engine.runningAnimations = [[element, {}, {}]];
+
+      Engine.initializeAnimation(element, 'stop');
+
+      expect(Engine.runningAnimations).to.have.length(0);
+    });
+
     describe('manual animations', () => {
       beforeEach(() => {
         sinon.stub(Animation, 'createAttentionAnimation');