Fixes dotnet#10633 - multiple statements simplified by removing explicit comparison (dotnet#10698)

Author: robbyc073

snippets/common/VS_Snippets_WebNet/Classic RequiredFieldValidator Example/Common/source.xml

@@ -6,7 +6,7 @@
 
        void ValidateBtn_Click(Object sender, EventArgs e) {
 
-          if (Page.IsValid == true) {
+          if (Page.IsValid) {
              lblOutput.Text = "Required field is filled!";
           }
           else {

snippets/cpp/VS_Snippets_CLR/AsyncDelegateExamples/cpp/polling.cpp

@@ -21,7 +21,7 @@ void main()
         threadId, nullptr, nullptr);
 
     // Poll while simulating work.
-    while(result->IsCompleted == false)
+    while(!result->IsCompleted)
     {
         Thread::Sleep(250);
         Console::Write(".");

snippets/cpp/VS_Snippets_CLR/T.TryParse/CPP/tp.cpp

@@ -16,7 +16,7 @@ static void Show( bool parseResult, String^ typeName, String^ parseValue )
    String^ msgFailure = L"** Parse for {0} failed. Invalid input.";
 
    //
-   if ( parseResult == true )
+   if ( parseResult )
       Console::WriteLine( msgSuccess, typeName, parseValue );
    else
       Console::WriteLine( msgFailure, typeName );

snippets/cpp/VS_Snippets_CLR/console.beep/CPP/beep.cpp

@@ -8,7 +8,7 @@ int main()
    int x = 0;
 
    //
-   if ( (args->Length == 2) && (Int32::TryParse( args[ 1 ],  x ) == true) && ((x >= 1) && (x <= 9)) )
+   if ( (args->Length == 2) && (Int32::TryParse( args[ 1 ],  x )) && ((x >= 1) && (x <= 9)) )
    {
       for ( int i = 1; i <= x; i++ )
       {

snippets/cpp/VS_Snippets_CLR/console.cursorvis/CPP/vis.cpp

@@ -21,7 +21,7 @@ int main()
    {
       Console::WriteLine( m1, ((Console::CursorVisible == true) ? (String^)"VISIBLE" : "HIDDEN") );
       s = Console::ReadLine();
-      if ( String::IsNullOrEmpty( s ) == false )
+      if ( !String::IsNullOrEmpty( s ) )
             if ( s[ 0 ] == '+' )
             Console::CursorVisible = true;
       else

snippets/cpp/VS_Snippets_CLR/console.keyavailable/CPP/ka.cpp

@@ -11,7 +11,7 @@ int main()
 
       // Your code could perform some useful task in the following loop. However, 
       // for the sake of this example we'll merely pause for a quarter second.
-      while ( Console::KeyAvailable == false )
+      while ( !Console::KeyAvailable )
             Thread::Sleep( 250 );
       cki = Console::ReadKey( true );
       Console::WriteLine( "You pressed the '{0}' key.", cki.Key );

snippets/cpp/VS_Snippets_CLR/directoryinfocreatesub/CPP/directoryinfocreatesub.cpp

@@ -9,7 +9,7 @@ int main()
    DirectoryInfo^ di = gcnew DirectoryInfo( "TempDir" );
 
    // Create the directory only if it does not already exist.
-   if ( di->Exists == false )
+   if ( !di->Exists )
       di->Create();
 
 

snippets/cpp/VS_Snippets_CLR_System/system.GC.ReRegisterForFinalize Example/CPP/class1.cpp

@@ -17,7 +17,7 @@ ref class MyFinalizeObject
 
    ~MyFinalizeObject()
    {
-      if ( hasFinalized == false )
+      if ( !hasFinalized )
       {
          Console::WriteLine( "First finalization" );
 

snippets/cpp/VS_Snippets_CLR_System/system.Random.Next/CPP/next3.cpp

@@ -8,7 +8,7 @@ void main()
    unsigned int numbers = 0;
    Random^ rnd = gcnew Random();
 
-   if (! UInt32::TryParse(line, numbers))
+   if (!UInt32::TryParse(line, numbers))
       numbers = 10;
 
    for (unsigned int ctr = 1; ctr <= numbers; ctr++)

snippets/cpp/VS_Snippets_CLR_System/system.String.Format/cpp/formatexample2.cpp

@@ -21,7 +21,7 @@ ref class CustomerFormatter : IFormatProvider, ICustomFormatter
 	               Object^ arg, 
 	               IFormatProvider^ formatProvider) 
    {                       
-      if (! this->Equals(formatProvider))
+      if (!this->Equals(formatProvider))
       {
          return nullptr;
       }

snippets/cpp/VS_Snippets_CLR_System/system.runtime.compilerservices.internalsvisibletoattribute/cpp/friend1.cpp

@@ -5,7 +5,7 @@ ref class FileUtilities
     public:
        static String^ AppendDirectorySeparator(String^ dir)
       {
-         if (! dir->Trim()->EndsWith(System::IO::Path::DirectorySeparatorChar.ToString()))
+         if (!dir->Trim()->EndsWith(System::IO::Path::DirectorySeparatorChar.ToString()))
             return dir->Trim() + System::IO::Path::DirectorySeparatorChar;
          else
             return dir;

snippets/cpp/VS_Snippets_Remoting/ClassicTcpClient.PublicMethodsAndPropertiesExample/CPP/source.cpp

@@ -166,7 +166,7 @@ public ref class MyTcpClientExample
       tcpClient->NoDelay = true;
 
       // Determines if the delay is enabled by using the NoDelay property.
-      if ( tcpClient->NoDelay == true )
+      if ( tcpClient->NoDelay)
             Console::WriteLine( "The delay was set successfully to {0}", tcpClient->NoDelay );
 
 

snippets/cpp/VS_Snippets_Remoting/DiscoveryDocument_DiscoveryDocument/CPP/discoverydocument_discoverydocument.cpp

@@ -41,7 +41,7 @@ int main()
       // <Snippet3>
       // <Snippet4>
       // Check whether the given XmlTextReader is readable.
-      if ( DiscoveryDocument::CanRead( myXmlTextReader ) == true )
+      if ( DiscoveryDocument::CanRead( myXmlTextReader ) )
 
       // Read the given XmlTextReader.
       myDiscoveryDocument = DiscoveryDocument::Read( myXmlTextReader );

snippets/cpp/VS_Snippets_Remoting/DiscoveryExceptionDictionary_Property_Method/CPP/discoveryexceptiondictionary_property_method.cpp

@@ -48,7 +48,7 @@ int main()
 
       // <Snippet2>
       DiscoveryExceptionDictionary^ myExceptionDictionary = myDiscoveryClientProtocol2->Errors;
-      if ( myExceptionDictionary->Contains( myUrlKey ) == true )
+      if ( myExceptionDictionary->Contains( myUrlKey ))
       {
          Console::WriteLine( "'myExceptionDictionary' contains a discovery exception for the key '{0}'", myUrlKey );
       }
@@ -57,7 +57,7 @@ int main()
          Console::WriteLine( "'myExceptionDictionary' does not contain a discovery exception for the key '{0}'", myUrlKey );
       }
       // </Snippet2>
-      if ( myExceptionDictionary->Contains( myUrlKey ) == true )
+      if ( myExceptionDictionary->Contains( myUrlKey ) )
       {
          Console::WriteLine( "System generated exceptions." );
 

snippets/cpp/VS_Snippets_Remoting/DiscoveryReferenceCollection/CPP/discoveryreferencecollection.cpp

@@ -38,7 +38,7 @@ int main()
    Console::WriteLine( "The number of elements in the collection after adding two elements to the collection: {0}", myDiscoveryReferenceCollection->Count );
 
    // Call the Contains method.
-   if ( myDiscoveryReferenceCollection->Contains( myDiscoveryDocReference1 ) != true )
+   if ( !myDiscoveryReferenceCollection->Contains( myDiscoveryDocReference1 ) )
    {
       throw gcnew Exception( "Element not found in collection." );
    }

snippets/cpp/VS_Snippets_Remoting/IChannelReceiver_StartListening_ChannelData/CPP/ichannelreceiver_channeldata_server.cpp

@@ -115,7 +115,7 @@ ref class MyCustomChannel: public IChannelReceiver
    // Start listening to the port.
    virtual void StartListening( Object^ data )
    {
-      if ( myListening == false )
+      if ( !myListening )
       {
          myTcpListener->Start();
          myListening = true;
@@ -128,7 +128,7 @@ ref class MyCustomChannel: public IChannelReceiver
    // Stop listening to the port.
    virtual void StopListening( Object^ data )
    {
-      if ( myListening == true )
+      if ( myListening )
       {
          myTcpListener->Stop();
          myListening = false;

snippets/cpp/VS_Snippets_Remoting/Message.Acknowledgment/CPP/message_acknowledgment.cpp

@@ -107,7 +107,7 @@ ref class MyNewQueue
          // This exception would be thrown if there is no (further) acknowledgment message
          // with the specified correlation Id. Only output a message if there are no messages;
          // not if the loop has found at least one.
-         if ( found == false )
+         if ( !found )
          {
             Console::WriteLine( e->Message );
          }

snippets/cpp/VS_Snippets_Remoting/MessageQueue.Receive_TimeoutTransaction/CPP/mqreceive_timeouttransaction.cpp

@@ -23,7 +23,7 @@ ref class MyNewQueue
       MessageQueue^ myQueue = gcnew MessageQueue( ".\\myTransactionalQueue" );
 
       // Send a message to the queue.
-      if ( myQueue->Transactional == true )
+      if ( myQueue->Transactional)
       {
          // Create a transaction.
          MessageQueueTransaction^ myTransaction = gcnew MessageQueueTransaction;

snippets/cpp/VS_Snippets_Remoting/MessageQueue.Receive_transaction/CPP/mqreceive_transaction.cpp

@@ -23,7 +23,7 @@ ref class MyNewQueue
       MessageQueue^ myQueue = gcnew MessageQueue( ".\\myTransactionalQueue" );
 
       // Send a message to the queue.
-      if ( myQueue->Transactional == true )
+      if ( myQueue->Transactional )
       {
          // Create a transaction.
          MessageQueueTransaction^ myTransaction = gcnew MessageQueueTransaction;

snippets/cpp/VS_Snippets_Remoting/MessageQueue.Send_ObjectTransaction/CPP/mqsend_objtransaction.cpp

@@ -23,7 +23,7 @@ ref class MyNewQueue
       MessageQueue^ myQueue = gcnew MessageQueue( ".\\myTransactionalQueue" );
 
       // Send a message to the queue.
-      if ( myQueue->Transactional == true )
+      if ( myQueue->Transactional )
       {
          // Create a transaction.
          MessageQueueTransaction^ myTransaction = gcnew MessageQueueTransaction;

snippets/cpp/VS_Snippets_Remoting/MessageQueue.Send_obj/CPP/mqsend_generic.cpp

@@ -16,7 +16,7 @@ ref class MyNewQueue
       MessageQueue^ myQueue = gcnew MessageQueue( ".\\myQueue" );
 
       // Send a message to the queue.
-      if ( myQueue->Transactional == true )
+      if ( myQueue->Transactional )
       {
 
          // Create a transaction.

snippets/cpp/VS_Snippets_Remoting/NCLCredPolicy/CPP/NCLCredPolicy.cpp

@@ -20,7 +20,7 @@ public ref class SelectedHostsCredentialPolicy: public ICredentialPolicy
    virtual bool ShouldSendCredential( Uri^ challengeUri, WebRequest^ request, NetworkCredential^ /*credential*/, IAuthenticationModule^ /*authModule*/ )
    {
       Console::WriteLine( L"Checking custom credential policy." );
-      if ( request->RequestUri->Host->Equals( L"www.contoso.com" ) || challengeUri->IsLoopback == true )
+      if ( request->RequestUri->Host->Equals( L"www.contoso.com" ) || challengeUri->IsLoopback )
             return true;
 
       return false;
@@ -41,7 +41,7 @@ public ref class HttpsBasicCredentialPolicy: public IntranetZoneCredentialPolicy
    {
       Console::WriteLine( L"Checking custom credential policy for HTTPS and basic." );
       bool answer = IntranetZoneCredentialPolicy::ShouldSendCredential( challengeUri, request, credential, authModule );
-      if ( answer == true )
+      if ( answer )
       {
          Console::WriteLine( L"Sending credential for intranet resource." );
          return answer;

snippets/cpp/VS_Snippets_Remoting/NCLFtpClient/CPP/ftptests.cpp

@@ -458,7 +458,7 @@ public ref class FtpRequestTest
       // Example: ftp://contoso.com/someFile.txt.
       // 
       // The command parameter identifies the command to send to the server.
-      if ( serverUri->ToLower()->StartsWith( Uri::UriSchemeFtp ) == false )
+      if ( !serverUri->ToLower()->StartsWith( Uri::UriSchemeFtp ) )
       {
          return false;
       }

snippets/cpp/VS_Snippets_Remoting/NCLNetInfo2/CPP/networkexamples.cpp

@@ -823,7 +823,7 @@ void DisplayIPv4NetworkInterfaces()
       NetworkInterface ^ adapter = safe_cast<NetworkInterface ^>(myEnum23->Current);
 
       // Only display informatin for interfaces that support IPv4.
-      if ( adapter->Supports( NetworkInterfaceComponent::IPv4 ) == false )
+      if ( !adapter->Supports( NetworkInterfaceComponent::IPv4 ) )
       {
          continue;
       }
@@ -875,7 +875,7 @@ void DisplayIPv6NetworkInterfaces()
       NetworkInterface ^ adapter = safe_cast<NetworkInterface ^>(myEnum24->Current);
 
       // Only display informatin for interfaces that support IPv6.
-      if ( adapter->Supports( NetworkInterfaceComponent::IPv6 ) == false )
+      if ( !adapter->Supports( NetworkInterfaceComponent::IPv6 ) )
       {
          continue;
       }

snippets/cpp/VS_Snippets_Remoting/NCLUriEnhancements/CPP/nclurienhancements.cpp

@@ -16,7 +16,7 @@ void SampleTryCreate()
 
    // Parse the string and create a new Uri instance, if possible.
    Uri^ result;
-   if ( Uri::TryCreate( addressString, UriKind::RelativeOrAbsolute, result ) == true )
+   if ( Uri::TryCreate( addressString, UriKind::RelativeOrAbsolute, result ) )
    {
       // The call was successful.  Write the URI address to the console.
       Console::Write( result );

snippets/cpp/VS_Snippets_Remoting/NCLUriExamples/CPP/uriexamples.cpp

@@ -112,7 +112,7 @@ namespace Example
 
          //<snippet1>
          char testChar = 'e';
-         if ( Uri::IsHexDigit( testChar ) == true )
+         if ( Uri::IsHexDigit( testChar ) )
          {
             Console::WriteLine( "'{0}' is the hexadecimal representation of {1}",
                testChar, Uri::FromHex( testChar ) );
@@ -236,7 +236,7 @@ namespace Example
 
 #if OLDMETHOD           
          Uri^ result;
-         if ( Uri::TryParse( uriString, false, false, result ) == true )
+         if ( Uri::TryParse( uriString, false, false, result ) )
          {
             Console::WriteLine( "{0} is a valid Uri", result );
          }

snippets/cpp/VS_Snippets_Remoting/NclMailASync/cpp/mailasync.cpp

@@ -76,7 +76,7 @@ int main(array<String^>^ args)
         String^ answer = Console::ReadLine();
         // If the user canceled the send, and mail hasn't been 
         // sent yet,then cancel the pending operation.
-        if (answer->ToLower()->StartsWith("c") && mailSent == false)
+        if (answer->ToLower()->StartsWith("c") && !mailSent)
         {
             client->SendAsyncCancel();
         }

snippets/cpp/VS_Snippets_Remoting/NclSslClientAsync/CPP/NclSslClientAsync.cpp

@@ -302,7 +302,7 @@ public ref class SslTcpClient
          // while waiting for the asynchronous calls to complete.
          System::Threading::Thread::Sleep( 100 );
       }
-      while ( complete != true && Console::KeyAvailable == false );
+      while ( !complete && !Console::KeyAvailable );
 
       if ( Console::KeyAvailable )
       {

snippets/cpp/VS_Snippets_Remoting/OperationCollection_Methods/CPP/operationcollection_methods.cpp

@@ -51,7 +51,7 @@ int main()
 
       // <Snippet3>
       // <Snippet4>
-      if ( myOperationCollection->Contains( myOperation ) == true )
+      if ( myOperationCollection->Contains( myOperation ))
       {
          Console::WriteLine( "The index of the added 'myOperation' operation is : {0}", myOperationCollection->IndexOf( myOperation ) );
       }

snippets/cpp/VS_Snippets_Remoting/OperationMessageCollection_Sample/CPP/operationmessagecollection_sample.cpp

@@ -93,7 +93,7 @@ int main()
 
       // <Snippet5>
       // <Snippet6>
-      if ( myOperationMessageCollection->Contains( myOperationMessage ) == true )
+      if ( myOperationMessageCollection->Contains( myOperationMessage ))
       {
          int myIndex = myOperationMessageCollection->IndexOf( myOperationMessage );
          Console::WriteLine( " The index of the Add operation message in the collection is : {0}", myIndex );

snippets/cpp/VS_Snippets_Remoting/Socket_Sync_Send_Receive/CPP/source.cpp

@@ -345,7 +345,7 @@ void RunUdpTests()
    Thread^ myThread1 = gcnew Thread( myThreadDelegate );
    myThread1->Start();
 
-   while ( myThread1->IsAlive == true )
+   while ( myThread1->IsAlive )
    {
       NeedForDelegates::SendTo1();
    }
@@ -354,7 +354,7 @@ void RunUdpTests()
    Console::WriteLine(  "UDP test2" );
    Thread^ myThread2 = gcnew Thread( gcnew ThreadStart( &NeedForDelegates::ReceiveFrom2 ) );
    myThread2->Start();
-   while ( myThread2->IsAlive == true )
+   while ( myThread2->IsAlive )
    {
       NeedForDelegates::SendTo2();
    }
@@ -363,7 +363,7 @@ void RunUdpTests()
    Console::WriteLine(  "UDP test3" );
    Thread^ myThread3 = gcnew Thread( gcnew ThreadStart( &NeedForDelegates::ReceiveFrom3 ) );
    myThread3->Start();
-   while ( myThread3->IsAlive == true )
+   while ( myThread3->IsAlive )
    {
       NeedForDelegates::SendTo3();
    }
@@ -372,7 +372,7 @@ void RunUdpTests()
    Console::WriteLine(  "UDP test4" );
    Thread^ myThread4 = gcnew Thread( gcnew ThreadStart( &NeedForDelegates::ReceiveFrom4 ) );
    myThread4->Start();
-   while ( myThread4->IsAlive == true )
+   while ( myThread4->IsAlive )
    {
       NeedForDelegates::SendTo4();
    }

snippets/cpp/VS_Snippets_Remoting/System.Net.ServicePoint/CPP/servicepoint.cpp

@@ -143,7 +143,7 @@ int main()
    }
 
    String^ proxy = args[ 1 ];
-   if ( (rex->Match(proxy))->Success != true )
+   if ( (!rex->Match(proxy))->Success)
    {
       Console::WriteLine( "Input string format not allowed." );
       return  -1;

snippets/cpp/VS_Snippets_Remoting/System.Net.ServicePointWhidbey/cpp/servicepoint.cpp

@@ -181,7 +181,7 @@ int main(array<String^>^ args)
     }
     String^ proxy = args[1];
 
-    if ((expression->Match(proxy))->Success != true)
+    if (!(expression->Match(proxy))->Success)
     {
         Console::WriteLine("Input string format not allowed.");
         return 0;

snippets/cpp/VS_Snippets_Winforms/Classic AttributeCollection.GetEnumerator Example/CPP/Source.cpp

@@ -26,7 +26,7 @@ public ref class Form1: public Form
       // Prints the type of each attribute in the collection.
       Object^ myAttribute;
       System::Text::StringBuilder^ text = gcnew System::Text::StringBuilder;
-      while ( ie->MoveNext() == true )
+      while ( ie->MoveNext() )
       {
          myAttribute = ie->Current;
          text->Append( myAttribute );

snippets/cpp/VS_Snippets_Winforms/Classic CheckedListBox Example/CPP/source.cpp

@@ -97,7 +97,7 @@ public ref class Form1: public System::Windows::Forms::Form
    {
       if (  !textBox1->Text->Equals( "" ) )
       {
-         if ( checkedListBox1->CheckedItems->Contains( textBox1->Text ) == false )
+         if ( !checkedListBox1->CheckedItems->Contains( textBox1->Text ) )
                   checkedListBox1->Items->Add( textBox1->Text, CheckState::Checked );
          textBox1->Text = "";
       }
@@ -154,7 +154,7 @@ public ref class Form1: public System::Windows::Forms::Form
       IEnumerator^ myEnumerator;
       myEnumerator = checkedListBox1->CheckedIndices->GetEnumerator();
       int y;
-      while ( myEnumerator->MoveNext() != false )
+      while ( myEnumerator->MoveNext() )
       {
          y = safe_cast<Int32>(myEnumerator->Current);
          checkedListBox1->SetItemChecked( y, false );