AHC Future.get should throw CancellationException when it was cancelled, close AsyncHttpClient#633

Author: Stephane Landelle

api/src/test/java/org/asynchttpclient/async/AsyncProvidersBasicTest.java

@@ -834,7 +834,7 @@ public Response onCompleted(Response response) throws Exception {
         }
     }
 
-    @Test(groups = { "standalone", "default_provider", "async" })
+    @Test(groups = { "standalone", "default_provider", "async" }, expectedExceptions = { CancellationException.class })
     public void asyncDoPostDelayCancelTest() throws Exception {
         AsyncHttpClient client = getAsyncHttpClient(null);
         try {
@@ -850,8 +850,8 @@ public void onThrowable(Throwable t) {
                 }
             });
             future.cancel(true);
-            Response response = future.get(TIMEOUT, TimeUnit.SECONDS);
-            assertNull(response);
+            future.get(TIMEOUT, TimeUnit.SECONDS);
+
         } finally {
             client.close();
         }

providers/netty3/src/main/java/org/asynchttpclient/providers/netty3/future/NettyResponseFuture.java

@@ -113,7 +113,7 @@ public NettyResponseFuture(Uri uri,//
 
     @Override
     public boolean isDone() {
-        return isDone.get() || isCancelled.get();
+        return isDone.get() || isCancelled();
     }
 
     @Override
@@ -161,6 +161,9 @@ public V get(long l, TimeUnit tu) throws InterruptedException, TimeoutException,
 
     private V getContent() throws ExecutionException {
 
+        if (isCancelled())
+            throw new CancellationException();
+
         ExecutionException e = exEx.get();
         if (e != null)
             throw e;
@@ -194,11 +197,14 @@ private V getContent() throws ExecutionException {
     /**   org.asynchttpclient.ListenableFuture  **/
     /*********************************************/
 
-    public final void done() {
-
+    private boolean terminateAndExit() {
         cancelTimeouts();
+        return isDone.getAndSet(true) || isCancelled.get();
+    }
 
-        if (isDone.getAndSet(true) || isCancelled.get())
+    public final void done() {
+
+        if (terminateAndExit())
             return;
 
         try {
@@ -219,9 +225,7 @@ public final void done() {
 
     public final void abort(final Throwable t) {
 
-        cancelTimeouts();
-
-        if (isDone.get() || isCancelled.getAndSet(true))
+        if (terminateAndExit())
             return;
 
         exEx.compareAndSet(null, new ExecutionException(t));

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/future/NettyResponseFuture.java

@@ -115,7 +115,7 @@ public NettyResponseFuture(Uri uri,//
 
     @Override
     public boolean isDone() {
-        return isDone.get() || isCancelled.get();
+        return isDone.get() || isCancelled();
     }
 
     @Override
@@ -163,6 +163,9 @@ public V get(long l, TimeUnit tu) throws InterruptedException, TimeoutException,
 
     private V getContent() throws ExecutionException {
 
+        if (isCancelled())
+            throw new CancellationException();
+
         ExecutionException e = exEx.get();
         if (e != null)
             throw e;
@@ -196,11 +199,14 @@ private V getContent() throws ExecutionException {
     /**   org.asynchttpclient.ListenableFuture  **/
     /*********************************************/
 
-    public final void done() {
-
+    private boolean terminateAndExit() {
         cancelTimeouts();
+        return isDone.getAndSet(true) || isCancelled.get();
+    }
 
-        if (isDone.getAndSet(true) || isCancelled.get())
+    public final void done() {
+
+        if (terminateAndExit())
             return;
 
         try {
@@ -221,9 +227,7 @@ public final void done() {
 
     public final void abort(final Throwable t) {
 
-        cancelTimeouts();
-
-        if (isDone.get() || isCancelled.getAndSet(true))
+        if (terminateAndExit())
             return;
 
         exEx.compareAndSet(null, new ExecutionException(t));