From 85e489461499b7098afa01b9782d4d5e0c59c407 Mon Sep 17 00:00:00 2001 From: Adam Lynch Date: Tue, 28 May 2013 09:16:31 +0200 Subject: [PATCH 1/5] Added a snippet about maximizing the browser A common problem. Previously, you had to set a chrome switch but now ChromeDriver2 supports maximizing via the wire protocol. --- README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index 7b378f9ef..bc50f8af9 100644 --- a/README.md +++ b/README.md @@ -378,3 +378,10 @@ $profile = new PHPWebDriver_WebDriverFirefoxProfile('path/to/a/firefox/profile') $session = $driver->session('firefox', array(), array(), $browser_profile=$profile); $session->close(); ``` + +## Full screen +* To maximize the browser window, simply use the API. Now works in Chrome since ChromeDriver version 2. + +```php +$session->window()->maximize(); +``` From 47bc8b3ae0d2f3bb328d80001c4d1d7bd6516e62 Mon Sep 17 00:00:00 2001 From: Aleksey Alekseev Date: Wed, 7 Aug 2013 10:17:41 +0400 Subject: [PATCH 2/5] changes from https://code.google.com/p/selenium/source/detail?r=8c3c65772d57 --- PHPWebDriver/WebDriver.php | 4 ++-- PHPWebDriver/WebDriverBase.php | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/PHPWebDriver/WebDriver.php b/PHPWebDriver/WebDriver.php index 6039cdfd1..ecb62e81f 100644 --- a/PHPWebDriver/WebDriver.php +++ b/PHPWebDriver/WebDriver.php @@ -56,8 +56,8 @@ public function session($browser = 'firefox', '/session', array('desiredCapabilities' => $desired_capabilities), $curl_opts); - // var_dump($results); - return new PHPWebDriver_WebDriverSession($results['info']['url']); + //var_dump($results); + return new PHPWebDriver_WebDriverSession($results['info']['url'].$results['sessionId']); } public function sessions($curl_opts = array()) { diff --git a/PHPWebDriver/WebDriverBase.php b/PHPWebDriver/WebDriverBase.php index f037dcd98..241baa9b5 100644 --- a/PHPWebDriver/WebDriverBase.php +++ b/PHPWebDriver/WebDriverBase.php @@ -196,9 +196,14 @@ protected function curl($http_method, $message = $value['message']; } + $sessionId=""; + if (is_array($results) && array_key_exists('sessionId', $results)) { + $sessionId = "/".$results['sessionId']; + } + self::throwException($results['status'], $message, $results); - return array('value' => $value, 'info' => $info); + return array('value' => $value, 'info' => $info, 'sessionId'=>$sessionId); } public function __call($name, $arguments) { From 893a258df2f564757fccbe67971559ab3d2b45f1 Mon Sep 17 00:00:00 2001 From: Piotr Repetowski Date: Tue, 20 Aug 2013 21:38:14 +0200 Subject: [PATCH 3/5] fix expected exception assertion --- test/AlertTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/AlertTest.php b/test/AlertTest.php index e1740e554..01f4e0192 100644 --- a/test/AlertTest.php +++ b/test/AlertTest.php @@ -116,7 +116,7 @@ public function testAlertSendKeys() { $a->sendKeys("cheese"); $fail = "PHPWebDriver_ElementNotDisplayedWebDriverError should have been thrown"; } catch (Exception $e) { - if (! is_a($e, "PHPWebDriver_ElementNotDisplayedWebDriverErro")) { + if (! is_a($e, "PHPWebDriver_ElementNotDisplayedWebDriverError")) { $fail = "exception should be PHPWebDriver_ElementNotDisplayedWebDriverError"; } } From b1a7a1c6baddc4af7e325ec05964d5e99f03e7ae Mon Sep 17 00:00:00 2001 From: Adam Goucher Date: Wed, 21 Aug 2013 20:58:01 -0400 Subject: [PATCH 4/5] change the name of the class to be accurate --- test/ActionChainsTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/ActionChainsTest.php b/test/ActionChainsTest.php index f127f1318..994a9062c 100644 --- a/test/ActionChainsTest.php +++ b/test/ActionChainsTest.php @@ -4,7 +4,7 @@ require_once(dirname(__FILE__) . '/../PHPWebDriver/WebDriverBy.php'); require_once(dirname(__FILE__) . '/../PHPWebDriver/WebDriverKeys.php'); -class ProxyTest extends PHPUnit_Framework_TestCase { +class ActionChainsTest extends PHPUnit_Framework_TestCase { protected static $session; public function setUp() { From 78245f11984bb75a1c3eed8df169d6b5e2445095 Mon Sep 17 00:00:00 2001 From: Adam Goucher Date: Wed, 21 Aug 2013 21:01:34 -0400 Subject: [PATCH 5/5] 1.12.0 release --- package.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.xml b/package.xml index 719250d87..5d7e3b5a0 100644 --- a/package.xml +++ b/package.xml @@ -16,10 +16,10 @@ adam@element34.ca yes - 2013-05-29 + 2013-08-22 - 1.11.0 - 1.11.0 + 1.12.0 + 1.12.0 stable