Skip to content

Commit 17cf00a

Browse files
authored
[ENH] Minor improvements to PR template
<!-- Pull-request guidelines ----------------------- 1. If you would like to list yourself as a Nipype contributor and your name is not mentioned please modify .zenodo.json file. 2. By submitting this request you acknowledge that your contributions are available under the Apache 2 license. 3. Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress) 4. The person who accepts/merges your PR will include an update to the CHANGES file: prefix: description (URL of pull request) 5. Run `make check-before-commit` before submitting the PR. --> ## Summary <!-- Please reference any related issue and use fixes/close to automatically close them, if pertinent --> After our experience with https://github.com/poldracklab/fmriprep/blob/master/docs/pull_request_template.md, I apply here @effigies suggestion of using HTML comments, and add a checkbox for the license. Please, have a look into FMRIPREP's template to decide whether we want to import any more ideas into nipype. ## List of changes proposed in this PR (pull-request) <!-- We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> - [x] Use HTML comments in the PR template to avoid asking contributors to remove text. ## Acknowledgment - [x] \(Mandatory\) I acknowledge that this contribution will be available under the Apache 2 license.
1 parent 7ea4f1b commit 17cf00a

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,24 @@
1-
Pull-request guidelines (Remove this section after reading):
1+
<!--
2+
3+
Pull-request guidelines
4+
-----------------------
25
36
1. If you would like to list yourself as a Nipype contributor and your name is not mentioned please modify .zenodo.json file.
47
2. By submitting this request you acknowledge that your contributions are available under the Apache 2 license.
58
3. Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress)
69
4. The person who accepts/merges your PR will include an update to the CHANGES file: prefix: description (URL of pull request)
710
5. Run `make check-before-commit` before submitting the PR.
811
9-
----- REMOVE TILL HERE -----
12+
-->
13+
## Summary
14+
<!-- Please reference any related issue and use fixes/close to automatically
15+
close them, if pertinent -->
1016

1117
Fixes # .
1218

13-
Changes proposed in this pull request
14-
-
15-
-
19+
## List of changes proposed in this PR (pull-request)
20+
<!-- We suggest using bullets (indicated by * or -) and filled checkboxes [x] here -->
21+
22+
## Acknowledgment
23+
24+
- [ ] \(Mandatory\) I acknowledge that this contribution will be available under the Apache 2 license.

0 commit comments

Comments
 (0)