Skip to content

Commit 16f81fb

Browse files
committed
Merge pull request airbnb#526 from taion/eslint-config-defaults
Eslint config defaults
2 parents d14e8b7 + 9c7674a commit 16f81fb

File tree

18 files changed

+568
-267
lines changed

18 files changed

+568
-267
lines changed

packages/eslint-config-airbnb/.eslintrc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
"rules": {
44
// disable requiring trailing commas because it might be nice to revert to
55
// being JSON at some point, and I don't want to make big changes now.
6-
"comma-dangle": 0,
7-
// disabled because I find it tedious to write tests while following this
8-
// rule
9-
"no-shadow": 0
6+
"comma-dangle": 0
107
}
118
}
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
module.exports = {
2+
'extends': [
3+
'./rules/best-practices.js',
4+
'./rules/errors.js',
5+
'./rules/es6.js',
6+
'./rules/legacy.js',
7+
'./rules/node.js',
8+
'./rules/strict.js',
9+
'./rules/style.js',
10+
'./rules/variables.js'
11+
],
12+
'parser': 'babel-eslint',
13+
'env': {
14+
'browser': true,
15+
'node': true,
16+
'amd': false,
17+
'mocha': false,
18+
'jasmine': false
19+
},
20+
'ecmaFeatures': {},
21+
'globals': {},
22+
'rules': {}
23+
};

packages/eslint-config-airbnb/base/index.js

Lines changed: 0 additions & 178 deletions
This file was deleted.
Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
1-
const reactRules = require('./react');
2-
const base = require('./base');
3-
4-
// clone this so we aren't mutating a module
5-
const eslintrc = JSON.parse(JSON.stringify(base));
6-
7-
// manually merge in React rules
8-
eslintrc.plugins = reactRules.plugins;
9-
Object.keys(reactRules.rules).forEach(function assignRule(ruleId) {
10-
eslintrc.rules[ruleId] = reactRules.rules[ruleId];
11-
});
12-
13-
module.exports = eslintrc;
1+
module.exports = {
2+
'extends': [
3+
// Need to qualify these here for ESLint to resolve them properly.
4+
'airbnb/base',
5+
'airbnb/rules/react.js'
6+
]
7+
};

packages/eslint-config-airbnb/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"description": "Airbnb's ESLint config, following our styleguide",
55
"main": "index.js",
66
"scripts": {
7-
"lint": "./node_modules/.bin/eslint .",
8-
"test": "./node_modules/.bin/babel-tape-runner ./test/test-*.js"
7+
"lint": "eslint .",
8+
"test": "babel-tape-runner ./test/test-*.js"
99
},
1010
"repository": {
1111
"type": "git",
@@ -26,10 +26,10 @@
2626
},
2727
"homepage": "https://github.com/airbnb/javascript",
2828
"devDependencies": {
29-
"babel-eslint": "4.0.10",
29+
"babel-eslint": "4.1.3",
3030
"babel-tape-runner": "1.2.0",
31-
"eslint": "1.3.0",
32-
"eslint-plugin-react": "3.2.3",
31+
"eslint": "1.5.1",
32+
"eslint-plugin-react": "3.4.2",
3333
"react": "0.13.3",
3434
"tape": "4.2.0"
3535
}

packages/eslint-config-airbnb/react.js

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)