-
Notifications
You must be signed in to change notification settings - Fork 9
Use i18n for common strings #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
How would these be distributed in releases? Putting them into subfolders like |
If I recall correctly, the TSC completely vetoed the translation. |
Can you link that? I thought they vetoed translating the docs themselves, (the files in core), not the strings we use to generate them (the files here). While we can't provide fully translated docs, we can at least translate some of the commonly used phrases (I.e. "Source Code: ", "Added in: ", etc.) |
cc @ovflowd |
I'll work on adding a --locale flag today. |
The TSC vettoed translation for the API docs. Navigation cues (and other common strings) should be translateable. Unfortunately due to the nature of API docs, these need to be purely on the client-side. In other words the "content" should not be translated, but anything that is layout/component should be translateable. Meaning:
|
Just confirming- we can do this on the client side w/o requiring js to run in the client's browser, correct? |
wdym? React is client side JavaScript running on the Client-Side browser. |
|
Ah yes, then it just goes to English :) |
But without JS you will also not be able to open the history and other features. Rendering the docs will still work but interactible elements maybe not. I guess we can do the history one with pure CSS maybe. |
Even the language seledctor could be pure CSS and just triggers elements with certain language to render based on class name. |
Sgtm - js is definitely needed for some of the features but I still wanna make sure it's not made necessary for the entire page |
Right now (in the draft generator) it is, but I'm actively working on getting React's dehydration to work, allowing the page to render without JS |
While we can't translate the docs themselves, we can translate some of our constant strings.
Now that i18n is publishable, we can add a --lang flag to the CLI to generate docs with different languages.
The text was updated successfully, but these errors were encountered: