From 5249bca7da20df6236abee9f3652e12b84532c5e Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Wed, 4 Jun 2025 14:09:03 -0400 Subject: [PATCH 1/4] feat(codecov): setup checks --- codecov.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 codecov.yml diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 0000000..0adbe43 --- /dev/null +++ b/codecov.yml @@ -0,0 +1,13 @@ +coverage: + # https://docs.codecov.com/docs/commit-status + status: + patch: + default: + # TODO(@avivkeller): Once our coverage > 80%, + # increase this to 80%, and move it to `default_rules` + target: 80% + project: + default: + # TODO(@avivkeller): Once our coverage > 50%, + # increase this to 50%, and increase on increments + target: 40% From c20997caa15ccf16144bb37123321b3f6c6a10bd Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Wed, 4 Jun 2025 17:10:45 -0400 Subject: [PATCH 2/4] fixup! ignore eslint and fixtures --- codecov.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/codecov.yml b/codecov.yml index 0adbe43..47205ff 100644 --- a/codecov.yml +++ b/codecov.yml @@ -11,3 +11,7 @@ coverage: # TODO(@avivkeller): Once our coverage > 50%, # increase this to 50%, and increase on increments target: 40% + +ignore: + - "eslint.config.mjs" + - "**/fixtures/**" From c0a3978e5ebb56823d5ea9c115b7c0acabae2367 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Wed, 4 Jun 2025 17:11:25 -0400 Subject: [PATCH 3/4] Update codecov.yml --- codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index 47205ff..db6a754 100644 --- a/codecov.yml +++ b/codecov.yml @@ -14,4 +14,4 @@ coverage: ignore: - "eslint.config.mjs" - - "**/fixtures/**" + - "**/fixtures/" From c22f9f121897940f8b99f120d5838bfda8534225 Mon Sep 17 00:00:00 2001 From: avivkeller Date: Thu, 5 Jun 2025 09:18:44 -0400 Subject: [PATCH 4/4] fixup! --- codecov.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/codecov.yml b/codecov.yml index db6a754..d452e83 100644 --- a/codecov.yml +++ b/codecov.yml @@ -4,7 +4,8 @@ coverage: patch: default: # TODO(@avivkeller): Once our coverage > 80%, - # increase this to 80%, and move it to `default_rules` + # remove this, since we can easily rely on + # project coverage to cover patches as well target: 80% project: default: @@ -13,5 +14,5 @@ coverage: target: 40% ignore: - - "eslint.config.mjs" - - "**/fixtures/" + - 'eslint.config.mjs' + - '**/fixtures/'