Fix and rename setDisableHttps setDisableAlgorithm, close AsyncHttpClient#1413

Motivation:

* it’s buggy and actually sets useInsecureTrustManager
* the name is not right

Modifications:

* change right property
* rename into `setDisableHttpsEndpointIdentificationAlgorithm`

Result:

It’s now possible to disable HTTPS endpointIdentificationAlgorithm, for
example in order to disable hostname verification.

Author: slandelle

client/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java

@@ -213,7 +213,7 @@ public interface AsyncHttpClientConfig {
     /**
      * @return true to disable all HTTPS behaviors AT ONCE, such as hostname verification and SNI
      */
-    boolean isDisableHttpsAlgorithm();
+    boolean isDisableHttpsEndpointIdentificationAlgorithm();
 
     /**
      * @return the array of enabled protocols

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java

@@ -97,7 +97,7 @@ public class DefaultAsyncHttpClientConfig implements AsyncHttpClientConfig {
     // ssl
     private final boolean useOpenSsl;
     private final boolean useInsecureTrustManager;
-    private final boolean disableHttpsAlgorithm;
+    private final boolean disableHttpsEndpointIdentificationAlgorithm;
     private final int handshakeTimeout;
     private final String[] enabledProtocols;
     private final String[] enabledCipherSuites;
@@ -172,7 +172,7 @@ private DefaultAsyncHttpClientConfig(//
             // ssl
             boolean useOpenSsl,//
             boolean useInsecureTrustManager,//
-            boolean disableHttpsAlgorithm,//
+            boolean disableHttpsEndpointIdentificationAlgorithm,//
             int handshakeTimeout,//
             String[] enabledProtocols,//
             String[] enabledCipherSuites,//
@@ -248,7 +248,7 @@ private DefaultAsyncHttpClientConfig(//
         // ssl
         this.useOpenSsl = useOpenSsl;
         this.useInsecureTrustManager = useInsecureTrustManager;
-        this.disableHttpsAlgorithm = disableHttpsAlgorithm;
+        this.disableHttpsEndpointIdentificationAlgorithm = disableHttpsEndpointIdentificationAlgorithm;
         this.handshakeTimeout = handshakeTimeout;
         this.enabledProtocols = enabledProtocols;
         this.enabledCipherSuites = enabledCipherSuites;
@@ -441,8 +441,8 @@ public boolean isUseInsecureTrustManager() {
     }
 
     @Override
-    public boolean isDisableHttpsAlgorithm() {
-        return disableHttpsAlgorithm;
+    public boolean isDisableHttpsEndpointIdentificationAlgorithm() {
+        return disableHttpsEndpointIdentificationAlgorithm;
     }
 
     @Override
@@ -655,7 +655,7 @@ public static class Builder {
         // ssl
         private boolean useOpenSsl = defaultUseOpenSsl();
         private boolean useInsecureTrustManager = defaultUseInsecureTrustManager();
-        private boolean disableHttpsAlgorithm = defaultDisableHttpsAlgorithm();
+        private boolean disableHttpsEndpointIdentificationAlgorithm = defaultDisableHttpsEndpointIdentificationAlgorithm();
         private int handshakeTimeout = defaultHandshakeTimeout();
         private String[] enabledProtocols = defaultEnabledProtocols();
         private String[] enabledCipherSuites = defaultEnabledCipherSuites();
@@ -934,8 +934,8 @@ public Builder setUseInsecureTrustManager(boolean useInsecureTrustManager) {
             return this;
         }
 
-        public Builder setDisableHttpsAlgorithm(boolean disableHttpsAlgorithm) {
-            this.useInsecureTrustManager = disableHttpsAlgorithm;
+        public Builder setDisableHttpsEndpointIdentificationAlgorithm(boolean disableHttpsEndpointIdentificationAlgorithm) {
+            this.disableHttpsEndpointIdentificationAlgorithm = disableHttpsEndpointIdentificationAlgorithm;
             return this;
         }
 
@@ -1167,7 +1167,7 @@ public DefaultAsyncHttpClientConfig build() {
                     keepAliveStrategy, //
                     useOpenSsl, //
                     useInsecureTrustManager, //
-                    disableHttpsAlgorithm, //
+                    disableHttpsEndpointIdentificationAlgorithm, //
                     handshakeTimeout, //
                     enabledProtocols, //
                     enabledCipherSuites, //

client/src/main/java/org/asynchttpclient/config/AsyncHttpClientConfigDefaults.java

@@ -119,8 +119,8 @@ public static boolean defaultUseInsecureTrustManager() {
         return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getBoolean(ASYNC_CLIENT_CONFIG_ROOT + "useInsecureTrustManager");
     }
 
-    public static boolean defaultDisableHttpsAlgorithm() {
-        return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getBoolean(ASYNC_CLIENT_CONFIG_ROOT + "disableHttpsAlgorithm");
+    public static boolean defaultDisableHttpsEndpointIdentificationAlgorithm() {
+        return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getBoolean(ASYNC_CLIENT_CONFIG_ROOT + "disableHttpsEndpointIdentificationAlgorithm");
     }
 
     public static int defaultSslSessionCacheSize() {

client/src/main/java/org/asynchttpclient/netty/ssl/SslEngineFactoryBase.java

@@ -23,7 +23,7 @@ public abstract class SslEngineFactoryBase implements SslEngineFactory {
 
     protected void configureSslEngine(SSLEngine sslEngine, AsyncHttpClientConfig config) {
         sslEngine.setUseClientMode(true);
-        if (!config.isDisableHttpsAlgorithm()) {
+        if (!config.isDisableHttpsEndpointIdentificationAlgorithm()) {
             SSLParameters params = sslEngine.getSSLParameters();
             params.setEndpointIdentificationAlgorithm("HTTPS");
             sslEngine.setSSLParameters(params);

client/src/main/resources/ahc-default.properties

@@ -24,7 +24,7 @@ org.asynchttpclient.disableUrlEncodingForBoundRequests=false
 org.asynchttpclient.removeQueryParamOnRedirect=true
 org.asynchttpclient.useOpenSsl=false
 org.asynchttpclient.useInsecureTrustManager=false
-org.asynchttpclient.disableHttpsAlgorithm=false
+org.asynchttpclient.disableHttpsEndpointIdentificationAlgorithm=false
 org.asynchttpclient.sslSessionCacheSize=0
 org.asynchttpclient.sslSessionTimeout=0
 org.asynchttpclient.tcpNoDelay=true