Skip to content

Commit 275b815

Browse files
authored
feat: Target new Datastore Client after microgenerator migration (GoogleCloudPlatform#4858)
* test: target new-generator * fix(datastore-admin): generated client creation has moved * fix(datastore-admin): replace other datastore admin paths * fix: update admin tests to use new style params * fix: changes to admin surface * chore: blacken/lint * chore: update pin for datastore * chore: update pin for firestore libs * chore(deps): update datastore pin * chore(deps): update firestore pin * chore(deps): update firestore pin for firebase * chore: use f strings * fix: remove unneeded specifying of name param
1 parent f113007 commit 275b815

File tree

9 files changed

+363
-359
lines changed

9 files changed

+363
-359
lines changed

datastore/cloud-client/admin.py

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,17 @@
1212
# limitations under the License.
1313

1414
# [START datastore_admin_client_create]
15-
from google.cloud.datastore_admin_v1.gapic import datastore_admin_client
15+
from google.cloud.datastore_admin_v1 import DatastoreAdminClient
1616

1717

1818
def client_create():
1919
"""Creates a new Datastore admin client."""
20-
client = datastore_admin_client.DatastoreAdminClient()
20+
client = DatastoreAdminClient()
2121

2222
print("Admin client created\n")
2323
return client
24+
25+
2426
# [END datastore_admin_client_create]
2527

2628

@@ -32,13 +34,17 @@ def export_entities(project_id, output_url_prefix):
3234
"""
3335
# project_id = "project-id"
3436
# output_url_prefix = "gs://bucket-name"
35-
client = datastore_admin_client.DatastoreAdminClient()
37+
client = DatastoreAdminClient()
3638

37-
op = client.export_entities(project_id, output_url_prefix)
39+
op = client.export_entities(
40+
{"project_id": project_id, "output_url_prefix": output_url_prefix}
41+
)
3842
response = op.result(timeout=200)
3943

4044
print("Entities were exported\n")
4145
return response
46+
47+
4248
# [END datastore_admin_entities_export]
4349

4450

@@ -47,13 +53,17 @@ def import_entities(project_id, input_url):
4753
"""Imports entities into Datastore."""
4854
# project_id := "project-id"
4955
# input_url := "gs://bucket-name/overall-export-metadata-file"
50-
client = datastore_admin_client.DatastoreAdminClient()
56+
client = DatastoreAdminClient()
5157

52-
op = client.import_entities(project_id, input_url)
58+
op = client.import_entities(
59+
{"project_id": project_id, "input_url": input_url}
60+
)
5361
response = op.result(timeout=200)
5462

5563
print("Entities were imported\n")
5664
return response
65+
66+
5767
# [END datastore_admin_entities_import]
5868

5969

@@ -62,25 +72,29 @@ def get_index(project_id, index_id):
6272
"""Gets an index."""
6373
# project_id := "my-project-id"
6474
# index_id := "my-index"
65-
client = datastore_admin_client.DatastoreAdminClient()
66-
index = client.get_index(project_id, index_id)
75+
client = DatastoreAdminClient()
76+
index = client.get_index({"project_id": project_id, "index_id": index_id})
6777

6878
print("Got index: %v\n", index.index_id)
6979
return index
80+
81+
7082
# [END datastore_admin_index_get]
7183

7284

7385
# [START datastore_admin_index_list]
7486
def list_indexes(project_id):
7587
"""Lists the indexes."""
7688
# project_id := "my-project-id"
77-
client = datastore_admin_client.DatastoreAdminClient()
89+
client = DatastoreAdminClient()
7890

7991
indexes = []
80-
for index in client.list_indexes(project_id):
92+
for index in client.list_indexes({"project_id": project_id}):
8193
indexes.append(index)
8294
print("Got index: %v\n", index.index_id)
8395

8496
print("Got list of indexes\n")
8597
return indexes
98+
99+
86100
# [END datastore_admin_index_list]

datastore/cloud-client/quickstart.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,22 @@ def run_quickstart():
2424
datastore_client = datastore.Client()
2525

2626
# The kind for the new entity
27-
kind = 'Task'
27+
kind = "Task"
2828
# The name/ID for the new entity
29-
name = 'sampletask1'
29+
name = "sampletask1"
3030
# The Cloud Datastore key for the new entity
3131
task_key = datastore_client.key(kind, name)
3232

3333
# Prepares the new entity
3434
task = datastore.Entity(key=task_key)
35-
task['description'] = 'Buy milk'
35+
task["description"] = "Buy milk"
3636

3737
# Saves the entity
3838
datastore_client.put(task)
3939

40-
print('Saved {}: {}'.format(task.key.name, task['description']))
40+
print(f"Saved {task.key.name}: {task['description']}")
4141
# [END datastore_quickstart]
4242

4343

44-
if __name__ == '__main__':
44+
if __name__ == "__main__":
4545
run_quickstart()

datastore/cloud-client/quickstart_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@
1818
def test_quickstart(capsys):
1919
quickstart.run_quickstart()
2020
out, _ = capsys.readouterr()
21-
assert 'Saved' in out
21+
assert "Saved" in out
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
google-cloud-datastore==1.15.3
1+
google-cloud-datastore==2.0.0

0 commit comments

Comments
 (0)