Skip to content

Commit 307cc61

Browse files
t-naabust-naabus
committed
Merge branch 't-naabus/textfixing' of https://github.com/Microsoft/PowerBI-JavaScript into t-naabus/textfixing
2 parents 873345d + 441e0d3 commit 307cc61

File tree

6 files changed

+35
-35
lines changed

6 files changed

+35
-35
lines changed

‎demo/code-demo/report.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<div id="left-pane" class="halfWidth right">
1919
<div id="embedArea">
20-
<h3>Embedded Report Area</h3>
20+
<h3>Embedded report area</h3>
2121
<h5>The following div id is <b>reportContainer</b>. In code, we embed a report to it.</h5>
2222
<div id="reportContainer" style="width: 800px; height: 600px; background: #DDDDDD;"></div>
2323
</div>

‎demo/code-demo/step_authorize.html‎

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,44 @@
11
<!DOCTYPE html>
22
<div class="line">
3-
<h4>Sample Report</h4>
4-
To Embed using a sample report, you can just move to next step.<br/>
5-
<button id="nextStepWithSample" class="btn btn-primary" onclick="OpenEmbedStepWithSample()">Embed Sample Report</button><br/><br/><br/>
6-
<a href="#" onclick="ToggleEmbedWithSpecificReportDiv()">Embed Your Own Report</a><br/>
3+
<h4>Sample report</h4>
4+
To embed using a report supplied with the sample, select <b>Embed sample report</b>.<br/>
5+
<button id="nextStepWithSample" class="btn btn-primary" onclick="OpenEmbedStepWithSample()">Embed sample report</button><br/><br/><br/>
6+
<a href="#" onclick="ToggleEmbedWithSpecificReportDiv()">Embed your own report</a><br/>
77
</div>
88
<div id="EmbedWithSpecificReportDiv" style="display: none;">
99
<div class="line">
1010
<h4>Prerequisites</h4>
1111
<ul>
12-
<li>A workspace in <a href="https://azure.microsoft.com/en-us/documentation/articles/power-bi-embedded-get-started/">Azure PowerBI Embedded Service.</a></li>
13-
<li>PowerBI Report imported to your workspace.</li>
12+
<li>A workspace in the <a href="https://azure.microsoft.com/en-us/documentation/articles/power-bi-embedded-get-started/">Power BI embedded service.</a></li>
13+
<li>PowerBI report imported to your workspace.</li>
1414
</ul>
1515
</div>
1616
<br/>
1717
<div class="line">
18-
<h4>Flow</h4>
19-
Once you have a report imported to PowerBI Workspace, you are ready to embed it.<br/>
20-
To Embed a report you need to get an Embed-Token. You can create this token in multiple ways:<br/>
18+
<h4>Instructions to get embed token</h4>
19+
Once you have a report imported to Power BI workspace, you are ready to embed it.<br/>
20+
<br/>
21+
To embed a report, you need to get an embed-Token. You can create this token in multiple ways.<br/>
2122
<ul>
2223
<li>Using <a href="https://github.com/Microsoft/PowerBI-cli">PowerBI-Cli</a> tool.<br/></li>
23-
<li>In .Net Code using <a href="http://www.nuget.org/packages/Microsoft.PowerBI.Core/">Microsoft.PowerBI.Core</a> package.<br/></li>
24-
<li>In NodeJS code using <a href="https://github.com/Microsoft/PowerBI-Node">powerbi-api</a> package.<br/></li>
24+
<li>From .Net Code using <a href="http://www.nuget.org/packages/Microsoft.PowerBI.Core/">Microsoft.PowerBI.Core</a> package.<br/></li>
25+
<li>From NodeJS code using <a href="https://github.com/Microsoft/PowerBI-Node">powerbi-api</a> package.<br/></li>
2526
</ul>
2627
</div>
2728
<br/>
2829
<div class="line">
29-
<h4>Enter Embed Details</h4>
30+
<h4>Enter embed details</h4>
3031

31-
Enter Report Embed Token</br>
32+
Enter report embed token<br/>
3233
<input type="text" id="txtAccessToken" name="txtAccessToken" onchange="UpdateSessions();" style="width: 100%;" /><br/><br/>
3334

34-
Enter Report Embedded Url</br>
35+
Enter report embedded url<br/>
3536
<input type="text" id="txtReportEmbed" name="txtReportEmbed" onchange="UpdateSessions();" style="width: 100%;" value="https://embedded.powerbi.com/appTokenReportEmbed" /><br/><br/>
3637

37-
Enter Report Id</br>
38+
Enter report id<br/>
3839
<input type="text" id="txtEmbedReportId" name="txtEmbedReportId" onchange="UpdateSessions();" style="width: 100%;" /><br/>
3940
</div>
40-
<button id="nextStep" class="btn btn-primary" onclick="OpenEmbedStep()">Next Step - Embed</button>
41+
<button id="nextStep" class="btn btn-primary" onclick="OpenEmbedStep()">Next step - embed</button>
4142
</div>
4243

4344
<script>

‎demo/code-demo/step_embed.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
<div id="settings">
33
<table id="report-embed-table">
44
<tr>
5-
<td class="td-field-name">Embed Token</td>
5+
<td class="td-field-name">Embed token</td>
66
<td><input type="text" id="txtAccessToken" onchange="UpdateSessions();" /><br/></td>
77
</tr>
88
<tr>
9-
<td class="td-field-name">Embed Url</td>
9+
<td class="td-field-name">Embed url</td>
1010
<td>
1111
<input type="text" id="txtReportEmbed" onchange="UpdateSessions();" value="https://embedded.powerbi.com/appTokenReportEmbed"/>
1212
</td>

‎demo/code-demo/step_interact.html‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,26 @@
22
<div id="step-interact-wrapper">
33
<div>
44
<div>
5-
<h8>Report supports the following functionality. Press to try!</h8>
5+
<h8>The report supports the following functionality. Select an item to give it a try!</h8>
66
</div>
77
<div class="break-float">
88
<ul id="operations-ul">
9-
<li id="report-operations-li" class="active" onclick="OpenReportOperations();"><a href="#">Show Report Operations</a></li>
10-
<li id="page-operations-li" onclick="OpenPageOperations();"><a href="#">Show Page Operations</a></li>
9+
<li id="report-operations-li" class="active" onclick="OpenReportOperations();"><a href="#">Show report operations</a></li>
10+
<li id="page-operations-li" onclick="OpenPageOperations();"><a href="#">Show page operations</a></li>
1111
</ul>
1212
</div>
1313
<div id="report-operations-div" class="operations-div">
14-
<button class="btn btn-margin" onclick="Report_GetId()">Get Id</button>
15-
<button class="btn btn-margin" onclick="Report_GetPages()">Get Pages</button>
16-
<button class="btn btn-margin" onclick="Report_SetPage()">Set Page</button>
17-
<button class="btn btn-margin" onclick="Report_SetFilters()">Set Filters</button>
18-
<button class="btn btn-margin" onclick="Report_GetFilters()">Get Filters</button>
19-
<button class="btn btn-margin" onclick="Report_RemoveFilters()">Remove Filters</button>
14+
<button class="btn btn-margin" onclick="Report_GetId()">Get id</button>
15+
<button class="btn btn-margin" onclick="Report_GetPages()">Get pages</button>
16+
<button class="btn btn-margin" onclick="Report_SetPage()">Set page</button>
17+
<button class="btn btn-margin" onclick="Report_SetFilters()">Set filters</button>
18+
<button class="btn btn-margin" onclick="Report_GetFilters()">Get filters</button>
19+
<button class="btn btn-margin" onclick="Report_RemoveFilters()">Remove filters</button>
2020
<button class="btn btn-margin" onclick="Report_PrintCurrentReport()">Print</button>
21-
<button class="btn btn-margin" onclick="Report_UpdateSettings()">Update Settings</button>
21+
<button class="btn btn-margin" onclick="Report_UpdateSettings()">Update settings</button>
2222
<button class="btn btn-margin" onclick="Report_Reload()">Reload</button>
23-
<button class="btn btn-margin" onclick="Report_FullScreen()">Full Screen</button>
24-
<button class="btn btn-margin" onclick="Report_ExitFullScreen()">Exit Full Screen</button>
23+
<button class="btn btn-margin" onclick="Report_FullScreen()">Full screen</button>
24+
<button class="btn btn-margin" onclick="Report_ExitFullScreen()">Exit full screen</button>
2525
</div>
2626
<div id="page-operations-div" class="operations-div" style="display: none;">
2727
<button class="btn btn-margin" onclick="Page_SetActive()">Set Active</button>
@@ -33,11 +33,11 @@
3333
<div id="codeDiv">
3434
<h4>Code</h4>
3535
<pre id="inputCode" style="width: 100%; height:200px;" /><br/>
36-
<button id="btnRunSampleCode" class="btn btn-primary">Run Code</button>
36+
<button id="btnRunSampleCode" class="btn btn-primary">Run code</button>
3737
</div>
3838

3939
<div id="result-wrap">
40-
The following div id is <b>result</b>. print to it in code for debugging.
40+
The following div id is <b>result</b>. You can print to it in code for debugging purposes.
4141
<pre id="result"></pre>
4242
</div>
4343
</div>

‎dist/powerbi.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"start": "http-server ./demo",
1616
"version": "gulp build && git add .",
1717
"prepublish": "typings install && gulp build",
18-
"postinstall": "cd demo && npm install",
1918
"test": "gulp test",
2019
"gulp": "gulp",
2120
"typings": "typings"

0 commit comments

Comments
 (0)