8357621

Hi all,

  please review this minor touch-up of the G1BiasedArray classes, removing some unused methods and improving method visibility a bit.

Testing: gha

Thanks,
  Thomas

Author: tschatzl

src/hotspot/share/gc/g1/g1BiasedArray.cpp

@@ -57,11 +57,4 @@ void G1BiasedMappedArrayBase::verify_biased_index(idx_t biased_index) const {
             biased_index, bias(), length());
 }
 
-void G1BiasedMappedArrayBase::verify_biased_index_inclusive_end(idx_t biased_index) const {
-  guarantee(_biased_base != nullptr, "Array not initialized");
-  guarantee(biased_index >= bias() && biased_index <= (bias() + length()),
-            "Biased index out of inclusive bounds, index: %zu bias: %zu length: %zu",
-            biased_index, bias(), length());
-}
-
 #endif

src/hotspot/share/gc/g1/g1BiasedArray.hpp

@@ -38,19 +38,6 @@ class G1BiasedMappedArrayBase : public CHeapObj<mtGC> {
 
   void* _alloc_base;      // the address the unpadded array has been allocated to
 
-public:
-  typedef size_t idx_t;
-
-protected:
-  address _base;          // the real base address
-  size_t _length;         // the length of the array
-  address _biased_base;   // base address biased by "bias" elements
-  size_t _bias;           // the bias, i.e. the offset biased_base is located to the right in elements
-  uint _shift_by;         // the amount of bits to shift right when mapping to an index of the array.
-
-protected:
-  G1BiasedMappedArrayBase();
-
   // Allocate a new array, generic version.
   address create_new_base_array(size_t length, size_t elem_size);
 
@@ -67,6 +54,18 @@ class G1BiasedMappedArrayBase : public CHeapObj<mtGC> {
     _shift_by = shift_by;
   }
 
+public:
+  typedef size_t idx_t;
+
+protected:
+  address _base;          // the real base address
+  size_t _length;         // the length of the array
+  address _biased_base;   // base address biased by "bias" elements
+  size_t _bias;           // the bias, i.e. the offset biased_base is located to the right in elements
+  uint _shift_by;         // the amount of bits to shift right when mapping to an index of the array.
+
+  G1BiasedMappedArrayBase();
+
   // Allocate and initialize this array to cover the heap addresses in the range
   // of [bottom, end).
   void initialize(HeapWord* bottom, HeapWord* end, size_t target_elem_size_in_bytes, size_t mapping_granularity_in_bytes) {
@@ -90,7 +89,6 @@ class G1BiasedMappedArrayBase : public CHeapObj<mtGC> {
 
   void verify_index(idx_t index) const PRODUCT_RETURN;
   void verify_biased_index(idx_t biased_index) const PRODUCT_RETURN;
-  void verify_biased_index_inclusive_end(idx_t biased_index) const PRODUCT_RETURN;
 
 public:
   virtual ~G1BiasedMappedArrayBase();
@@ -103,10 +101,15 @@ class G1BiasedMappedArrayBase : public CHeapObj<mtGC> {
 // heap into this array.
 template<class T>
 class G1BiasedMappedArray : public G1BiasedMappedArrayBase {
+
+  T* base() const { return (T*)G1BiasedMappedArrayBase::_base; }
+
+  // The raw biased base pointer.
+  T* biased_base() const { return (T*)G1BiasedMappedArrayBase::_biased_base; }
+    
 public:
   typedef G1BiasedMappedArrayBase::idx_t idx_t;
 
-  T* base() const { return (T*)G1BiasedMappedArrayBase::_base; }
   // Return the element of the given array at the given index. Assume
   // the index is valid. This is a convenience method that does sanity
   // checking on the index.
@@ -123,9 +126,6 @@ class G1BiasedMappedArray : public G1BiasedMappedArrayBase {
     this->base()[index] = value;
   }
 
-  // The raw biased base pointer.
-  T* biased_base() const { return (T*)G1BiasedMappedArrayBase::_biased_base; }
-
   // Return the element of the given array that covers the given word in the
   // heap. Assumes the index is valid.
   T get_by_address(HeapWord* value) const {
@@ -166,15 +166,6 @@ class G1BiasedMappedArray : public G1BiasedMappedArrayBase {
     }
   }
 
-protected:
-  // Returns the address of the element the given address maps to
-  T* address_mapped_to(HeapWord* address) {
-    idx_t biased_index = ((uintptr_t)address) >> this->shift_by();
-    this->verify_biased_index_inclusive_end(biased_index);
-    return biased_base() + biased_index;
-  }
-
-public:
   // Return the smallest address (inclusive) in the heap that this array covers.
   HeapWord* bottom_address_mapped() const {
     return (HeapWord*) ((uintptr_t)this->bias() << this->shift_by());
@@ -194,6 +185,7 @@ class G1BiasedMappedArray : public G1BiasedMappedArrayBase {
       set_by_index(i, value);
     }
   }
+
 public:
   G1BiasedMappedArray() {}