Skip to content

Commit 74df384

Browse files
committed
8352428: GenShen: Old-gen cycles are still looping
Reviewed-by: wkemper, shade
1 parent fcc2a24 commit 74df384

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ void ShenandoahHeuristics::record_cycle_end() {
188188

189189
bool ShenandoahHeuristics::should_start_gc() {
190190
if (_start_gc_is_pending) {
191+
log_trigger("GC start is already pending");
191192
return true;
192193
}
193194
// Perform GC to cleanup metaspace

src/hotspot/share/gc/shenandoah/shenandoahRegulatorThread.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ void ShenandoahRegulatorThread::regulate_young_and_old_cycles() {
8080
}
8181
} else if (_old_heuristics->should_resume_old_cycle() || _old_heuristics->should_start_gc()) {
8282
if (request_concurrent_gc(_heap->old_generation())) {
83+
_old_heuristics->cancel_trigger_request();
8384
log_debug(gc)("Heuristics request to resume old collection accepted");
8485
}
8586
}

0 commit comments

Comments
 (0)