squash: review feedback

Author: dougxc

docs/reference-manual/embedding/embed-languages.md

@@ -413,7 +413,7 @@ This table shows the level of optimizations the Java runtimes currently provide:
 
 | Java Runtime                                  | Runtime Optimization Level                          |
 |-----------------------------------------------|-----------------------------------------------------|
-| Oracle GraalVM                                | Optimized with additional compiler passes           |
+| Oracle GraalVM                                | Best (includes additional compiler optimizations)   |
 | GraalVM Community Edition                     | Optimized                                           |
 | Oracle JDK                                    | Optimized via VM option                             |
 | OpenJDK                                       | Optimized via VM option and `--upgrade-module-path` |

sdk/mx.sdk/mx_sdk.py

@@ -271,7 +271,7 @@ def __init__(self):
             additional_vm_args = []
         elif GraalVMJDKConfig.is_libgraal_jdk(default_jdk.home):
             # Oracle JDK includes the libjvmci compiler, allowing it to function as GraalVM.
-            # However, the Graal compiler is disabled by default and must be explicitly enabled using the -XX:+UseJVMCICompiler option.
+            # However, the Graal compiler is disabled by default and must be explicitly enabled using the -XX:+UseGraalJIT option.
             graalvm_home = default_jdk.home
             additional_vm_args = ['-XX:+UnlockExperimentalVMOptions', '-XX:+EnableJVMCI', '-XX:+UseGraalJIT', '-XX:-UnlockExperimentalVMOptions']
         else:

sdk/mx.sdk/mx_sdk_vm.py

@@ -776,7 +776,8 @@ def _get_image_vm_options(jdk, use_upgrade_module_path, modules, synthetic_modul
     if default_to_jvmci or 'jdk.graal.compiler' in non_synthetic_modules:
         threads = get_JVMCIThreadsPerNativeLibraryRuntime(jdk)
         vm_options.extend(['-XX:+UnlockExperimentalVMOptions', '-XX:+EnableJVMCIProduct'])
-        # As of JDK-8345826, the JVMCI module must be explicitly added to the root set
+        # -XX:+EnableJVMCI must be explicitly specified to the java launcher to add
+        # jdk.internal.vm.ci to the root set (JDK-8345826)
         vm_options.append('-XX:+EnableJVMCI')
         if threads is not None and threads != 1:
             vm_options.append('-XX:JVMCIThreadsPerNativeLibraryRuntime=1')