Skip to content

Commit 6f6126d

Browse files
committed
unlink if no patterns are passing that aren't also in failing patterns
1 parent 3c5bf33 commit 6f6126d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

graalpython/com.oracle.graal.python.test/src/tests/test_tagged_unittests.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,12 @@ def get_pass_name(funcname, classname):
208208
# the same function is shared in multiple test classes, and
209209
# fails in some. so we always subtract the failed patterns from
210210
# the passed patterns
211+
passing_only_patterns = set(passing_tests) - set(failed_tests)
211212
with open(tagfile, "w") as f:
212-
for passing_test in set(passing_tests) - set(failed_tests):
213+
for passing_test in passing_only_patterns:
213214
f.write(passing_test)
214215
f.write("\n")
215-
if not passing_tests:
216+
if not passing_only_patterns:
216217
os.unlink(tagfile)
217218
else:
218219
# we tried the last time and failed, so our tags don't work for

0 commit comments

Comments
 (0)