[GR-15195] Correct a guard for binary operations on truffle objects to prefer interpretation as long over double

timfel · timfel · commit 83a6900f9457 · 2019-04-16T06:20:15.000-07:00
PullRequest: graalpython/487
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/foreign/TruffleObjectBuiltins.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/foreign/TruffleObjectBuiltins.java
@@ -230,7 +230,7 @@ Object doComparisonLong(Object left, Object right,
             }
         }
 
-        @Specialization(guards = {"lib.fitsInDouble(left)"})
+        @Specialization(guards = {"!lib.fitsInLong(left)", "lib.fitsInDouble(left)"})
         Object doComparisonDouble(Object left, Object right,
                         @CachedLibrary(limit = "3") InteropLibrary lib) {
             try {

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ Object doComparisonLong(Object left, Object right,`
`230`	`230`	`}`
`231`	`231`	`}`
`232`	`232`
`233`		`- @Specialization(guards = {"lib.fitsInDouble(left)"})`
	`233`	`+ @Specialization(guards = {"!lib.fitsInLong(left)", "lib.fitsInDouble(left)"})`
`234`	`234`	`Object doComparisonDouble(Object left, Object right,`
`235`	`235`	`@CachedLibrary(limit = "3") InteropLibrary lib) {`
`236`	`236`	`try {`