Raise an exception when file_put_contents() fails

Author: sebastianbergmann

ChangeLog-5.3.md

@@ -4,6 +4,10 @@ All notable changes of the PHP_CodeCoverage 5.3 release series are documented in
 
 ## [5.3.1] - 2017-MM-DD
 
+### Changed
+
+* `Clover`, `Crap4j`, and `PHP` report writers now raise an exception when their call to `file_put_contents()` fails
+
 ### Fixed
 
 * Fixed [#559](https://github.com/sebastianbergmann/php-code-coverage/issues/559): Ignored classes and methods are reported as 100% covered

src/Report/Clover.php

@@ -12,6 +12,7 @@
 
 use SebastianBergmann\CodeCoverage\CodeCoverage;
 use SebastianBergmann\CodeCoverage\Node\File;
+use SebastianBergmann\CodeCoverage\RuntimeException;
 
 /**
  * Generates a Clover XML logfile from a code coverage object.
@@ -24,6 +25,8 @@ class Clover
      * @param string       $name
      *
      * @return string
+     *
+     * @throws \SebastianBergmann\CodeCoverage\RuntimeException
      */
     public function process(CodeCoverage $coverage, $target = null, $name = null)
     {
@@ -243,7 +246,14 @@ public function process(CodeCoverage $coverage, $target = null, $name = null)
                 \mkdir(\dirname($target), 0777, true);
             }
 
-            \file_put_contents($target, $buffer);
+            if (@\file_put_contents($target, $buffer) === false) {
+                throw new RuntimeException(
+                    \sprintf(
+                        'Could not write to "%s',
+                        $target
+                    )
+                );
+            }
         }
 
         return $buffer;

src/Report/Crap4j.php

@@ -13,6 +13,7 @@
 use SebastianBergmann\CodeCoverage\CodeCoverage;
 use SebastianBergmann\CodeCoverage\InvalidArgumentException;
 use SebastianBergmann\CodeCoverage\Node\File;
+use SebastianBergmann\CodeCoverage\RuntimeException;
 
 class Crap4j
 {
@@ -42,6 +43,8 @@ public function __construct($threshold = 30)
      * @param string       $name
      *
      * @return string
+     *
+     * @throws \SebastianBergmann\CodeCoverage\RuntimeException
      */
     public function process(CodeCoverage $coverage, $target = null, $name = null)
     {
@@ -135,7 +138,14 @@ public function process(CodeCoverage $coverage, $target = null, $name = null)
                 \mkdir(\dirname($target), 0777, true);
             }
 
-            \file_put_contents($target, $buffer);
+            if (@\file_put_contents($target, $buffer) === false) {
+                throw new RuntimeException(
+                    \sprintf(
+                        'Could not write to "%s',
+                        $target
+                    )
+                );
+            }
         }
 
         return $buffer;

src/Report/PHP.php

@@ -27,7 +27,7 @@ public function process(CodeCoverage $coverage, $target = null)
     {
         $filter = $coverage->filter();
 
-        $output = \sprintf(
+        $buffer = \sprintf(
             '<?php
 $coverage = new SebastianBergmann\CodeCoverage\CodeCoverage;
 $coverage->setData(%s);
@@ -43,9 +43,16 @@ public function process(CodeCoverage $coverage, $target = null)
         );
 
         if ($target !== null) {
-            return \file_put_contents($target, $output);
-        } else {
-            return $output;
+            if (@\file_put_contents($target, $buffer) === false) {
+                throw new RuntimeException(
+                    \sprintf(
+                        'Could not write to "%s',
+                        $target
+                    )
+                );
+            }
         }
+
+        return $buffer;
     }
 }