Skip to content

Commit 1fe802a

Browse files
authored
Makes kokos more robust (GoogleCloudPlatform#760)
1 parent bf963cc commit 1fe802a

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

datastore/tutorial/test/FunctionsTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ class FunctionsTest extends TestCase
2525
{
2626
use EventuallyConsistentTestTrait;
2727

28+
/* @var $retryCount int */
29+
protected static $retryCount = 5;
30+
2831
/* @var $hasCredentials boolean */
2932
protected static $hasCredentials;
3033

@@ -103,7 +106,7 @@ public function testListTasks()
103106
}
104107
}
105108
$this->assertEquals(1, $found, 'It should list a new task.');
106-
});
109+
}, self::$retryCount);
107110
}
108111

109112
public function tearDown()

testing/run_test_suite.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ ALT_PROJECT_TESTS=(
4343
datastore/tutorial
4444
dialogflow
4545
dlp
46+
error_reporting
4647
kms
48+
logging
4749
monitoring
4850
pubsub/api
4951
storage
@@ -86,7 +88,7 @@ run_tests()
8688
fi
8789
if [[ "${ALT_PROJECT_TESTS[@]}" =~ "${DIR}" ]] && [ ! -z "$GOOGLE_ALT_PROJECT_ID" ]; then
8890
echo "Using alternate project $GOOGLE_ALT_PROJECT_ID"
89-
GOOGLE_PROJECT_ID=$GOOGLE_ALT_PROJECT_ID GOOGLE_STORAGE_BUCKET=$GOOGLE_ALT_STORAGE_BUCKET $CMD
91+
GCLOUD_PROJECT=$GOOGLE_ALT_PROJECT_ID GOOGLE_PROJECT_ID=$GOOGLE_ALT_PROJECT_ID GOOGLE_STORAGE_BUCKET=$GOOGLE_ALT_STORAGE_BUCKET $CMD
9092
else
9193
$CMD
9294
fi

vision/test/visionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ public function testPdfGcs()
291291
{
292292
$this->requireCloudStorage();
293293

294-
$source = 'gs://' . $this->bucketName . '/HodgeConj.pdf';
294+
$source = 'gs://' . $this->bucketName . '/vision/HodgeConj.pdf';
295295
$destination = 'gs://' . $this->bucketName . '/OCR_PDF_TEST_OUTPUT/';
296296
$output = $this->runCommand('pdf', $source, $destination);
297297
$this->assertContains('Output files:', $output);

0 commit comments

Comments
 (0)