When debug is enabled, Netty ConnectListener erroneously consumes a retry token, close AsyncHttpClient#436

Author: Stephane Landelle

src/main/java/com/ning/http/client/providers/netty/NettyConnectListener.java

@@ -33,6 +33,7 @@
 import org.slf4j.LoggerFactory;
 
 import javax.net.ssl.HostnameVerifier;
+
 import java.io.IOException;
 import java.net.ConnectException;
 import java.net.InetSocketAddress;
@@ -85,8 +86,9 @@ public final void operationComplete(ChannelFuture f) throws Exception {
         } else {
             Throwable cause = f.getCause();
 
-            logger.debug("Trying to recover a dead cached channel {} with a retry value of {} ", f.getChannel(), future.canRetry());
-            if (future.canRetry() && cause != null && (NettyAsyncHttpProvider.abortOnDisconnectException(cause)
+            boolean canRetry = future.canRetry();
+            logger.debug("Trying to recover a dead cached channel {} with a retry value of {} ", f.getChannel(), canRetry);
+            if (canRetry && cause != null && (NettyAsyncHttpProvider.abortOnDisconnectException(cause)
                     || cause instanceof ClosedChannelException
                     || future.getState() != NettyResponseFuture.STATE.NEW)) {