feat(storage): introduce failing tests to indentify problem

Author: davideast

package.json

@@ -1,6 +1,6 @@
 {
   "name": "angularfire2",
-  "version": "5.0.0-rc.5",
+  "version": "5.0.0-rc.5-next",
   "description": "The official library of Firebase and Angular.",
   "private": true,
   "scripts": {
@@ -35,7 +35,7 @@
     "@angular/platform-browser": "^5.0.0",
     "@angular/platform-browser-dynamic": "^5.0.0",
     "firebase": "^4.5.0",
-    "rxjs": "^5.5.2",
+    "rxjs": "^5.5.4",
     "zone.js": "^0.8.0"
   },
   "devDependencies": {

src/storage/storage.spec.ts

@@ -51,6 +51,18 @@ describe('AngularFireStorage', () => {
           });
     });
 
+    it('should upload a file and observe the download url', (done) => {
+      const data = { angular: "fire" };
+      const blob = new Blob([JSON.stringify(data)], { type : 'application/json' });
+      const ref = afStorage.ref('afs.json');
+      const task = ref.put(blob);
+      const url$ = task.downloadURL();
+      url$.subscribe(
+        url => { console.log(url); expect(url).toBeDefined(); },
+        e => { done.fail(); },
+        () => { ref.delete().subscribe(done, done.fail); }
+      );
+    });
   });
 
   describe('reference', () => {

src/storage/task.ts

@@ -1,7 +1,7 @@
 import { storage } from 'firebase/app';
 import { fromTask } from './observable/fromTask';
 import { Observable } from 'rxjs/Observable';
-import { map, filter } from 'rxjs/operators';
+import { map, filter, shareReplay } from 'rxjs/operators';
 
 export interface AngularFireUploadTask {
   snapshotChanges(): Observable<storage.UploadTaskSnapshot | undefined>;
@@ -15,6 +15,7 @@ export interface AngularFireUploadTask {
 }
 
 export function createUploadTask(task: storage.UploadTask): AngularFireUploadTask {
+  const inner$ = fromTask(task).pipe(shareReplay());
   return { 
     pause() { return task.pause(); },    
     cancel() { return task.cancel(); },    
@@ -23,17 +24,15 @@ export function createUploadTask(task: storage.UploadTask): AngularFireUploadTas
     catch(onRejected: (a: Error) => any) { 
       return task.catch(onRejected);
     },
-    snapshotChanges() { return fromTask(task); },   
+    snapshotChanges() { return inner$; },   
     percentageChanges() { 
-      return fromTask(task).pipe(
+      return inner$.pipe(
         filter(s => s !== undefined),
-        map(s => {
-          return s!.bytesTransferred / s!.totalBytes * 100;
-        })
+        map(s => s!.bytesTransferred / s!.totalBytes * 100)
       );
     },
     downloadURL() {
-      return fromTask(task).pipe(
+      return inner$.pipe(
         filter(s => s !== undefined),
         filter(s => s!.bytesTransferred === s!.totalBytes),
         map(s => s!.downloadURL)

tools/build.js

@@ -22,6 +22,7 @@ const GLOBALS = {
   'rxjs/operator/combineLatest': 'Rx.Observable.prototype',
   'rxjs/operator/merge': 'Rx.Observable.prototype',
   'rxjs/operator/map': 'Rx.Observable.prototype',
+  'rxjs/operators': 'Rx.Observable.prototype',
   'rxjs/observable/of': 'Rx.Observable',
   'rxjs/observable/forkJoin': 'Rx.Observable',
   'rxjs/operator/auditTime': 'Rx.Observable.prototype',

yarn.lock

@@ -3390,11 +3390,11 @@ [email protected]:
   version "2.3.24"
   resolved "https://registry.yarnpkg.com/rx/-/rx-2.3.24.tgz#14f950a4217d7e35daa71bbcbe58eff68ea4b2b7"
 
-rxjs@^5.5.2:
-  version "5.5.2"
-  resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-5.5.%3Cspan%20class="x x-first x-last">2.tgz#28d403f0071121967f18ad665563255d54236ac3"
+rxjs@^5.5.4:
+  version "5.5.4"
+  resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-5.5.%3Cspan%20class="x x-first x-last">4.tgz#66a466acb21270b5f441645a1141f95fcae10ee6"
   dependencies:
-    symbol-observable "^1.0.1"
+    symbol-observable "1.0.1"
 
 safe-buffer@^5.0.1, safe-buffer@~5.1.0, safe-buffer@~5.1.1:
   version "5.1.1"
@@ -3688,9 +3688,9 @@ supports-color@^4.0.0:
   dependencies:
     has-flag "^2.0.0"
 
-symbol-observable@^1.0.1:
-  version "1.0.4"
-  resolved "https://registry.yarnpkg.com/symbol-observable/-/symbol-observable-1.0.%3Cspan%20class="x x-first x-last">4.tgz#29bf615d4aa7121bdd898b22d4b3f9bc4e2aa03d"
+[email protected]:
+  version "1.0.1"
+  resolved "https://registry.yarnpkg.com/symbol-observable/-/symbol-observable-1.0.%3Cspan%20class="x x-first x-last">1.tgz#8340fc4702c3122df5d22288f88283f513d3fdd4"
 
 systemjs-builder@^0.15.7:
   version "0.15.36"