Skip to content

Commit 4e3b517

Browse files
committed
Port some fixes
1 parent 42b0805 commit 4e3b517

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

src/main/java/com/ning/http/client/RequestBuilderBase.java

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public RequestImpl(Request prototype) {
9595
this.proxyServer = prototype.getProxyServer();
9696
this.realm = prototype.getRealm();
9797
this.file = prototype.getFile();
98-
this.followRedirects = prototype.isRedirectOverrideSet()? prototype.isRedirectEnabled() : null;
98+
this.followRedirects = prototype.isRedirectOverrideSet() ? prototype.isRedirectEnabled() : null;
9999
this.perRequestConfig = prototype.getPerRequestConfig();
100100
this.rangeOffset = prototype.getRangeOffset();
101101
this.charset = prototype.getBodyEncoding();
@@ -126,7 +126,7 @@ public InetAddress getInetAddress() {
126126
public InetAddress getLocalAddress() {
127127
return localAddress;
128128
}
129-
129+
130130
private String toUrl(boolean encode) {
131131

132132
if (url == null) {
@@ -271,7 +271,7 @@ public boolean isRedirectEnabled() {
271271
return (followRedirects != null && followRedirects);
272272
}
273273

274-
public boolean isRedirectOverrideSet(){
274+
public boolean isRedirectOverrideSet() {
275275
return followRedirects != null;
276276
}
277277

@@ -294,18 +294,22 @@ public String toString() {
294294
sb.append("\t");
295295
sb.append(method);
296296
sb.append("\theaders:");
297-
for (String name : headers.keySet()) {
298-
sb.append("\t");
299-
sb.append(name);
300-
sb.append(":");
301-
sb.append(headers.getJoinedValue(name, ", "));
297+
if (headers != null && !headers.isEmpty()) {
298+
for (String name : headers.keySet()) {
299+
sb.append("\t");
300+
sb.append(name);
301+
sb.append(":");
302+
sb.append(headers.getJoinedValue(name, ", "));
303+
}
302304
}
303-
sb.append("\tparams:");
304-
for (String name : params.keySet()) {
305-
sb.append("\t");
306-
sb.append(name);
307-
sb.append(":");
308-
sb.append(params.getJoinedValue(name, ", "));
305+
if (params != null && !params.isEmpty()) {
306+
sb.append("\tparams:");
307+
for (String name : params.keySet()) {
308+
sb.append("\t");
309+
sb.append(name);
310+
sb.append(":");
311+
sb.append(params.getJoinedValue(name, ", "));
312+
}
309313
}
310314

311315
return sb.toString();
@@ -339,10 +343,10 @@ public T setUrl(String url) {
339343
}
340344

341345
public T setInetAddress(InetAddress address) {
342-
request.address = address;
343-
return derived.cast(this);
346+
request.address = address;
347+
return derived.cast(this);
344348
}
345-
349+
346350
public T setLocalInetAddress(InetAddress address) {
347351
request.localAddress = address;
348352
return derived.cast(this);

0 commit comments

Comments
 (0)