Merge pull request trungvose#79 from darxx/Unit-testing

Unit testing

Author: trungvose

frontend/karma.conf.js

@@ -25,8 +25,25 @@ module.exports = function (config) {
     colors: true,
     logLevel: config.LOG_INFO,
     autoWatch: true,
-    browsers: ['Chrome'],
+    browsers: ['ChromeHeadless'],
     singleRun: false,
-    restartOnFileChange: true
+    restartOnFileChange: true,
+    customLaunchers: {
+      HeadlessChrome: {
+        base: 'ChromeHeadless',
+        flags: [
+          '--disable-web-security',
+          '--disable-setuid-sandbox',
+          '--no-sandbox',
+          '--headless',
+          '--disable-gpu',
+          '--disable-translate',
+          '--disable-extensions',
+          '--proxy-server=\'direct://\'',
+          '--proxy-bypass-list=*',
+          '--blockDomainsExcept',
+        ]
+      }
+    },
   });
 };

frontend/package.json

@@ -6,6 +6,7 @@
     "start": "ng serve",
     "build": "ng build --prod=true --sourceMap=true",
     "test": "ng test",
+    "test-cover": "ng test --code-coverage --source-map=false",
     "lint": "ng lint",
     "lint:fix": "ng lint --fix=true",
     "e2e": "ng e2e",

frontend/src/app/app-route.module.spec.ts

@@ -0,0 +1,18 @@
+import {TestBed} from '@angular/core/testing';
+import {AppRoutingModule} from '@trungk18/app-routing.module';
+import {RouterTestingModule} from '@angular/router/testing';
+
+describe('AppRoutingModule', () => {
+  let module: AppRoutingModule;
+
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      imports: [AppRoutingModule, RouterTestingModule]
+    });
+    module = TestBed.inject(AppRoutingModule);
+  });
+
+  it('should have App Routing Module', () => {
+    expect(module).toBeTruthy();
+  });
+});

frontend/src/app/app.component.spec.ts

@@ -0,0 +1,54 @@
+import { AppComponent } from '@trungk18/app.component';
+import { NavigationEnd } from '@angular/router';
+import { environment } from '../environments/environment';
+
+describe('AppComponent', () => {
+  let component: AppComponent;
+
+  const router: any = {
+    events: {
+      subscribe: jasmine.createSpy('subscribe')
+    }
+  };
+  const projectQuery: any = {};
+  const changeDetectorRef: any = {
+    detectChanges: jasmine.createSpy('detectChanges')
+  };
+  const projectService: any = {
+    setLoading: jasmine.createSpy('setLoading').and.callThrough()
+  };
+  const googleAnalyticsService: any = {
+    sendPageView: jasmine.createSpy('sendPageView').and.callThrough()
+  };
+
+  beforeEach(() => {
+    environment.production = true;
+    component = new AppComponent(
+      router,
+      projectQuery,
+      changeDetectorRef,
+      projectService,
+      googleAnalyticsService
+    );
+  });
+  it('should be able to set Loading', () => {
+    expect(router.events.subscribe).toHaveBeenCalled();
+    expect(projectService.setLoading).toHaveBeenCalledWith(true);
+  });
+  it('should be able to make ng After View Init', () => {
+    component.ngAfterViewInit();
+    expect(changeDetectorRef.detectChanges).toHaveBeenCalled();
+  });
+  it('should be able to handle Google Analytics', () => {
+    component.handleGoogleAnalytics( new NavigationEnd(1, '/', '/'));
+
+    expect(googleAnalyticsService.sendPageView).toHaveBeenCalled();
+  });
+  it('should not be able to handle Google Analytics', () => {
+    googleAnalyticsService.sendPageView.calls.reset();
+    component.handleGoogleAnalytics({ });
+
+    expect(googleAnalyticsService.sendPageView).not.toHaveBeenCalled();
+  });
+
+});

frontend/src/app/app.component.ts

@@ -20,17 +20,16 @@ export class AppComponent implements AfterViewInit {
     private _googleAnalytics: GoogleAnalyticsService
   ) {
     this._projectService.setLoading(true);
+
     if (environment.production) {
-      this.handleGoogleAnalytics();
+      this.router.events.subscribe(this.handleGoogleAnalytics);
     }
   }
 
-  handleGoogleAnalytics() {
-    this.router.events.subscribe((event) => {
-      if (event instanceof NavigationEnd) {
-        this._googleAnalytics.sendPageView(event.urlAfterRedirects);
-      }
-    });
+  handleGoogleAnalytics = (event: any): void => {
+    if (event instanceof NavigationEnd) {
+      this._googleAnalytics.sendPageView(event.urlAfterRedirects);
+    }
   }
 
   ngAfterViewInit() {

frontend/src/app/app.module.spec.ts

@@ -0,0 +1,17 @@
+import { AppModule } from '@trungk18/app.module';
+import { TestBed } from '@angular/core/testing';
+
+describe('AppModule', () => {
+  let module: AppModule;
+
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      imports: [AppModule]
+    });
+    module = TestBed.inject(AppModule);
+  });
+
+  it('should have app module', () => {
+    expect(module).toBeTruthy();
+  });
+});

frontend/src/app/core/services/google-analytics.service.spec.ts

@@ -0,0 +1,44 @@
+import {GoogleAnalyticsService} from '@trungk18/core/services/google-analytics.service';
+
+describe('GoogleAnalyticsService', () => {
+  let service: GoogleAnalyticsService;
+  beforeEach(() => {
+    service = new GoogleAnalyticsService();
+
+  });
+
+  it('should be able to sendEvent', () => {
+    service.gtag = jasmine.createSpy('gtag').and.returnValue(true);
+    service.sendEvent(
+     '',
+     '',
+     '',
+     null
+    );
+    expect(service.gtag).toHaveBeenCalled();
+  });
+  it('should not be able to sendEvent', () => {
+    service.gtag = false;
+
+    expect(service.sendEvent(
+      '',
+      '',
+      '',
+      null
+    )).toEqual();
+  });
+  it('should be able to sendPageView', () => {
+    service.gtag = jasmine.createSpy('gtag').and.returnValue(true);
+    service.sendPageView(
+     ''
+    );
+    expect(service.gtag).toHaveBeenCalled();
+  });
+  it('should not be able to sendPageView', () => {
+    service.gtag = false;
+
+    expect(service.sendPageView(
+      ''
+    )).toEqual();
+  });
+});

frontend/src/app/core/services/google-analytics.service.ts

@@ -5,29 +5,33 @@ const GOOGLE_ANALYTICS_ID = 'UA-80363801-4';
   providedIn: 'root'
 })
 export class GoogleAnalyticsService {
+  gtag: any;
   constructor() {
+    if (typeof gtag !== 'undefined') {
+      this.gtag = gtag;
+    }
   }
 
-  public sendEvent(
+  public sendEvent = (
     eventName: string,
     eventCategory: string,
     eventLabel: string = null,
     eventValue: number = null
-  ) {
-    if (!gtag) {
+  ) => {
+    if (!this.gtag) {
       return;
     }
-    gtag('event', eventName, {
+    this.gtag('event', eventName, {
       event_category: eventCategory,
       event_label: eventLabel,
       value: eventValue
     });
   }
 
   public sendPageView(url: string) {
-    if (!gtag) {
+    if (!this.gtag) {
       return;
     }
-    gtag('config', GOOGLE_ANALYTICS_ID, { page_path: url });
+    this.gtag('config', GOOGLE_ANALYTICS_ID, { page_path: url });
   }
 }

frontend/src/app/jira-control/jira-control.module.spec.ts

@@ -0,0 +1,23 @@
+import { TestBed } from '@angular/core/testing';
+import { JiraControlModule } from '@trungk18/jira-control/jira-control.module';
+import { ReactiveFormsModule } from '@angular/forms';
+import { CommonModule } from '@angular/common';
+
+describe('JiraControlModule', () => {
+  let module: JiraControlModule;
+
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      imports: [
+        CommonModule,
+        JiraControlModule,
+        ReactiveFormsModule
+      ]
+    });
+    module = TestBed.inject(JiraControlModule);
+  });
+
+  it('should have Jira Control Module', () => {
+    expect(module).toBeTruthy();
+  });
+});

frontend/src/app/project/components/issues/issue-card/issue-card.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input, OnChanges, SimpleChanges } from '@angular/core';
+import {Component, Input, OnChanges, OnInit, SimpleChanges} from '@angular/core';
 import { UntilDestroy, untilDestroyed } from '@ngneat/until-destroy';
 import { JIssue } from '@trungk18/interface/issue';
 import { IssuePriorityIcon } from '@trungk18/interface/issue-priority-icon';
@@ -14,7 +14,7 @@ import { IssueModalComponent } from '../issue-modal/issue-modal.component';
   styleUrls: ['./issue-card.component.scss']
 })
 @UntilDestroy()
-export class IssueCardComponent implements OnChanges {
+export class IssueCardComponent implements OnChanges, OnInit {
   @Input() issue: JIssue;
   assignees: JUser[];
   issueTypeIcon: string;