Skip to content

Commit a8df3d1

Browse files
authored
ext/curl: libcurl CURLOPT_{FTP_RESPONSE_TIMEOUT,ENCODING} replacements (#15126)
1 parent 82c504f commit a8df3d1

File tree

5 files changed

+21
-6
lines changed

5 files changed

+21
-6
lines changed

NEWS

+4
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ PHP NEWS
4141
EAI_SYSTEM not found). (nielsdos)
4242
. Implemented asymmetric visibility for properties. (ilutov)
4343

44+
- Curl:
45+
. Added CURLOPT_SERVER_RESPONSE_TIMEOUT, which was formerly known as
46+
CURLOPT_FTP_RESPONSE_TIMEOUT. (Ayesh Karunaratne)
47+
4448
- Date:
4549
. Fixed bug GH-13773 (DatePeriod not taking into account microseconds for end
4650
date). (Mark Bennewitz, Derick)

UPGRADING

+3
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,8 @@ PHP 8.4 UPGRADE NOTES
292292
supported (true) or not (false).
293293
. Added CURL_HTTP_VERSION_3 and CURL_HTTP_VERSION_3ONLY constants (available
294294
since libcurl 7.66 and 7.88) as available options for CURLOPT_HTTP_VERSION.
295+
. Added CURLOPT_SERVER_RESPONSE_TIMEOUT, which was formerly known as
296+
CURLOPT_FTP_RESPONSE_TIMEOUT. Both constants hold the same value.
295297

296298
- Date:
297299
. Added static methods
@@ -996,6 +998,7 @@ PHP 8.4 UPGRADE NOTES
996998
. CURL_HTTP_VERSION_3.
997999
. CURL_HTTP_VERSION_3ONLY.
9981000
. CURL_TCP_KEEPCNT
1001+
. CURLOPT_SERVER_RESPONSE_TIMEOUT.
9991002

10001003
- Intl:
10011004
. The IntlDateFormatter class exposes now the new PATTERN constant

ext/curl/curl.stub.php

+9-2
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@
8484
const CURLOPT_EGDSOCKET = UNKNOWN;
8585
/**
8686
* @var int
87-
* @cvalue CURLOPT_ENCODING
87+
* @cvalue CURLOPT_ACCEPT_ENCODING
88+
* @alias CURLOPT_ACCEPT_ENCODING
8889
*/
8990
const CURLOPT_ENCODING = UNKNOWN;
9091
/**
@@ -1291,9 +1292,15 @@
12911292
const CURLINFO_PROXYAUTH_AVAIL = UNKNOWN;
12921293
/**
12931294
* @var int
1294-
* @cvalue CURLOPT_FTP_RESPONSE_TIMEOUT
1295+
* @cvalue CURLOPT_SERVER_RESPONSE_TIMEOUT
1296+
* @alias CURLOPT_SERVER_RESPONSE_TIMEOUT
12951297
*/
12961298
const CURLOPT_FTP_RESPONSE_TIMEOUT = UNKNOWN;
1299+
/**
1300+
* @var int
1301+
* @cvalue CURLOPT_SERVER_RESPONSE_TIMEOUT
1302+
*/
1303+
const CURLOPT_SERVER_RESPONSE_TIMEOUT = UNKNOWN;
12971304
/**
12981305
* @var int
12991306
* @cvalue CURLOPT_IPRESOLVE

ext/curl/curl_arginfo.h

+4-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ext/curl/interface.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1695,7 +1695,7 @@ static zend_result _php_curl_setopt(php_curl *ch, zend_long option, zval *zvalue
16951695
case CURLOPT_HTTPAUTH:
16961696
case CURLOPT_FTP_CREATE_MISSING_DIRS:
16971697
case CURLOPT_PROXYAUTH:
1698-
case CURLOPT_FTP_RESPONSE_TIMEOUT:
1698+
case CURLOPT_SERVER_RESPONSE_TIMEOUT:
16991699
case CURLOPT_IPRESOLVE:
17001700
case CURLOPT_MAXFILESIZE:
17011701
case CURLOPT_TCP_NODELAY:

0 commit comments

Comments
 (0)